abstract installation id away from tools, update review events (now runs on draft -> open pr, DOESNT run on all new PR commits)

Author: sayansisodiya

src/github/client.ts

@@ -9,15 +9,32 @@ export class GitHubClient {
 
   constructor(config: Config, installationId?: number) {
     this.config = config;
-    this.installationId = installationId;
+    
+    // If no installationId provided, try to get from environment
+    if (installationId === undefined) {
+      const envId = parseInt(process.env.GITHUB_INSTALLATION_ID || '0', 10);
+      this.installationId = envId || undefined;
+    } else {
+      this.installationId = installationId;
+    }
+    
+    // Validate that we have some form of authentication
+    if (!this.installationId && !config.github.token) {
+      throw new Error('Missing authentication: set GITHUB_INSTALLATION_ID env var or github.token in config.yml');
+    }
+    
     const githubConfig = config.github;
-    this.baseUrl = githubConfig.base_url.replace(/\/$/, '');
+    this.baseUrl = (githubConfig.base_url ?? 'https://api.github.com').replace(/\/$/, '');
   }
 
   static forInstallation(config: Config, installationId: number): GitHubClient {
     return new GitHubClient(config, installationId);
   }
 
+  static fromEnv(config: Config): GitHubClient {
+    return new GitHubClient(config);
+  }
+
   private async getAuthHeaders(): Promise<Record<string, string>> {
     const headers = {
       'Accept': 'application/vnd.github.v3+json',

src/mcp/tools/get_pr_comments.ts

@@ -19,13 +19,7 @@ export async function getPRComments(
   try {
     const { owner, repo, pr_number } = args;
 
-    // Get installation ID from environment
-    const installationId = parseInt(process.env.GITHUB_INSTALLATION_ID || '0', 10);
-    if (!installationId) {
-      throw new Error('GITHUB_INSTALLATION_ID environment variable is required');
-    }
-
-    const githubClient = GitHubClient.forInstallation(config, installationId);
+    const githubClient = GitHubClient.fromEnv(config);
 
     const comments = await githubClient.getPRComments(owner, repo, pr_number);
 

src/mcp/tools/leave_comment.ts

@@ -15,13 +15,7 @@ export async function leaveGeneralComment(
   try {
     const { message, owner, repo, pr_number } = args;
 
-    // Get installation ID from environment
-    const installationId = parseInt(process.env.GITHUB_INSTALLATION_ID || '0', 10);
-    if (!installationId) {
-      throw new Error('GITHUB_INSTALLATION_ID environment variable is required');
-    }
-
-    const githubClient = GitHubClient.forInstallation(config, installationId);
+    const githubClient = GitHubClient.fromEnv(config);
     const response = await githubClient.createPRComment(owner, repo, pr_number, message);
 
     return {

src/mcp/tools/leave_inline_comment.ts

@@ -18,13 +18,7 @@ export async function leaveInlineComment(
   try {
     const { message, owner, repo, pr_number, path, line, commit_sha } = args;
 
-    // Get installation ID from environment
-    const installationId = parseInt(process.env.GITHUB_INSTALLATION_ID || '0', 10);
-    if (!installationId) {
-      throw new Error('GITHUB_INSTALLATION_ID environment variable is required');
-    }
-
-    const githubClient = GitHubClient.forInstallation(config, installationId);
+    const githubClient = GitHubClient.fromEnv(config);
 
     console.log('🎯 Creating inline comment via PR review:', { path, line });
 
@@ -54,7 +48,7 @@ export async function leaveInlineComment(
       owner, 
       repo, 
       pr_number, 
-      message,
+      '', // Empty body to avoid duplication
       'COMMENT',
       [{
         path,

src/routes/github.ts

@@ -11,6 +11,9 @@ const github = new Hono();
 // Initialize config for webhook route
 const config: Config = getConfig();
 
+// PR actions that trigger code reviews
+const REVIEW_TRIGGER_ACTIONS = ['opened', 'reopened', 'ready_for_review'];
+
 // We'll need to receive the reviewQueue from the main server
 let reviewQueue: ReviewJobQueue | null = null;
 
@@ -49,9 +52,9 @@ async function handleInstallationEvent(payload: unknown) {
  * Handle pull request events
  */
 async function handlePullRequestEvent(payload: GitHubPullRequestEvent) {
-  // Check if this is an action we care about (opened, reopened, synchronize)
+  // Check if this is an action we care about
   const action = payload.action;
-  if (!['opened', 'reopened', 'synchronize'].includes(action)) {
+  if (!REVIEW_TRIGGER_ACTIONS.includes(action)) {
     return { message: 'Action ignored' };
   }