chore: Keep env var names consistent for Grafana pgsql datasource #1105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcleblanc2
requested review from
a team and
DaedalusG
and removed request for
a team
marcleblanc2
changed the title
marcleblanc2
changed the title
jdpleiness
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While implementing these creds as Kubernetes secrets in the deploy-sourcegraph-helm repo in sourcegraph/deploy-sourcegraph-helm#568, the name of the env vars changed to match the format in the databaseAuth Helm template helper function, so I'm just updating the env var names to keep them consistent.
Issue:
https://linear.app/sourcegraph/issue/PS-91/update-env-vars-in-sgsg-to-match-helm-format
Checklist
Test plan
Manual testing