Skip to content

add pure docker deploy script for syntactic-code-intel-worker #1213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 28, 2025
+25 −0
Merged

add pure docker deploy script for syntactic-code-intel-worker #1213

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
99585ab
add pure docker deploy script for syntactic-code-intel-worker
DaedalusG May 28, 2025
156273c
Update pure-docker/deploy-syntactic-code-intel-worker.sh
DaedalusG May 28, 2025
4ab0a9e
make quotes for env vars consistent
DaedalusG May 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions pure-docker/deploy-syntactic-code-intel-worker.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
#!/usr/bin/env bash
set -e
source ./replicas.sh

# Description: High level syntax analysis
#
# Ports exposed to other Sourcegraph services: 3288/TCP
# Ports exposed to the public internet: none
#
docker run --detach \
--name=syntactic-code-intel-worker \
--network=sourcegraph \
--restart=always \
--cpus=2 \
--memory=4g \
-e SRC_FRONTEND_INTERNAL=sourcegraph-frontend-internal:3090 \
-e PRECISE_CODE_INTEL_UPLOAD_BACKEND=blobstore \
-e PRECISE_CODE_INTEL_UPLOAD_AWS_ENDPOINT=http://blobstore:9000 \
-e 'OTEL_EXPORTER_OTLP_ENDPOINT=http://otel-collector:4317' \
-e 'SYNTACTIC_CODE_INTEL_WORKER_ADDR=:3288' \
Copy link
Contributor

@varungandhi-src varungandhi-src May 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are some of these quoted and others not? Let's be consistent unless there is a specific reason to not be.

Copy link
Contributor Author

@DaedalusG DaedalusG May 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, I think the reason its inconsistent is just that some of the other shell scripts are inconsistent here and I used amp to generate it from reference

index.docker.io/sourcegraph/syntactic-code-intel-worker:6.1.1295@sha256:c6e2b097b8f16394e339588e208c43587f1fa6a35cb44e9759622c448ddc1445
Copy link
Contributor

@varungandhi-src varungandhi-src May 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we're pinning a SHA here, do we need to go in and update it on every release?

If so, do we need to update any release checklists for doing so?

Copy link
Contributor Author

@DaedalusG DaedalusG May 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't actually maintain up to date shas here. Check the release tags to see: https://github.com/sourcegraph/deploy-sourcegraph-docker/blob/v6.3.0/pure-docker/deploy-frontend.sh

It might be worth a later PR to fix this up though, and I'm thinking of adding a test to the pipeline to ensure that services defined in the docker-compose.yaml have a corresponding file here.


echo "Deployed syntactic-code-intel-worker service"