chore(ci): login with docker #1218
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
burmudar
force-pushed
the
wb/docker-login
branch
2 times, most recently
from
10859dd to
87d0568
Compare
burmudar
force-pushed
the
wb/docker-login
branch
5 times, most recently
from
daf8375 to
fec6899
Compare
jdpleiness
reviewed
Jun 9, 2025
DaedalusG
approved these changes
Jun 9, 2025
burmudar
added a commit
that referenced
this pull request
Jun 23, 2025
Ultimate goal: login with docker to get higher pull limits What it involved: - Rework how the `buildkite-agent` vm is built - sourcegraph/infrastructure#6848 - sourcegraph/infrastructure#6849 - sourcegraph/infrastructure#6850 - sourcegraph/infrastructure#6851 - sourcegraph/infrastructure#6852 - sourcegraph/infrastructure#6854 - sourcegraph/infrastructure#6855 - sourcegraph/infrastructure#6856 - Transition to mise - Use a specific version of vagrant (2.4.1) otherwise the an older incompatible version of `vagrant-google` (2.2.0) gets installed, 2.7.0 is the latest and correct one - Fix vagrant issues ### Test plan CI
burmudar
added a commit
that referenced
this pull request
Jun 23, 2025
This is a cherry-pick of 14a5138 --- Ultimate goal: login with docker to get higher pull limits What it involved: - Rework how the `buildkite-agent` vm is built - sourcegraph/infrastructure#6848 - sourcegraph/infrastructure#6849 - sourcegraph/infrastructure#6850 - sourcegraph/infrastructure#6851 - sourcegraph/infrastructure#6852 - sourcegraph/infrastructure#6854 - sourcegraph/infrastructure#6855 - sourcegraph/infrastructure#6856 - Transition to mise - Use a specific version of vagrant (2.4.1) otherwise the an older incompatible version of `vagrant-google` (2.2.0) gets installed, 2.7.0 is the latest and correct one - Fix vagrant issues ### Test plan CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ultimate goal: login with docker to get higher pull limits
What it involved:
buildkite-agentvm is builtvagrant-google(2.2.0) gets installed, 2.7.0 is the latest and correct oneCloses DINF-1148
Test plan
CI