test-connection: allow test-connection pod configuration #208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add `testConnection` to `values.yaml` * Modify `test-connection.yaml` to use templating * Add test-connection to configuration options in `README.md`
michaellzc
reviewed
Nov 4, 2022
Member
There was a problem hiding this comment.
the CI is failling
would you run ./scripts/helm-docs.sh?
let's also add some basic unit test https://github.com/sourcegraph/deploy-sourcegraph-helm/blob/main/TEST.md
| containers: | ||
| - name: wget | ||
| image: busybox | ||
| image: {{ .Values.testConnection.image.name }}:{{ .Values.testConnection.image.defaultTag }} |
Member
There was a problem hiding this comment.
let's use the helper partial template like other deployment
Suggested change
| image: {{ .Values.testConnection.image.name }}:{{ .Values.testConnection.image.defaultTag }} | |
| image: {{ include "sourcegraph.image" (list . "testConnection") }} |
abeatrix
approved these changes
Nov 4, 2022
Contributor
abeatrix
left a comment
abeatrix
left a comment
There was a problem hiding this comment.
Other than the suggestion pointed out by Michael, the rest looks good to me! thanks jacob!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for disabling or changing the
test-connectionspod. See issue #189.This PR makes the following changes:
testConnectionis enabled by default and uses thebusybox:latestimage from DockerHub.testConnectioncan be disabled or set to use a different image using theoverride.yamlfile.Checklist
Test plan
This is a change to a test. The manual testing process was followed as described above.