Skip to content

Conversation

@antonsviridov-src
Copy link
Contributor

@antonsviridov-src antonsviridov-src commented Feb 21, 2025

This was a mistake on my part – those two env variables are not used by syntactic worker itself, but by the part of precise worker that it embeds – so they should be exactly the same as in precise work

Checklist

Test plan

  • N/A

@jdpleiness
Copy link
Contributor

jdpleiness commented Mar 5, 2025

I ran these changes locally and all seems to run well:

❯ k get pods
NAME                                           READY   STATUS             RESTARTS        AGE
blobstore-bb4dfbfb8-57nt7                      1/1     Running            0               5m27s
cadvisor-q6vs6                                 0/1     CrashLoopBackOff   5 (2m4s ago)    5m27s
codeinsights-db-0                              2/2     Running            0               5m27s
codeintel-db-0                                 2/2     Running            0               5m27s
gitserver-0                                    1/1     Running            2 (3m45s ago)   5m27s
grafana-0                                      1/1     Running            0               5m27s
indexed-search-0                               2/2     Running            0               5m27s
node-exporter-7kdcg                            1/1     Running            0               5m27s
otel-agent-2t8jt                               1/1     Running            0               5m27s
otel-collector-8474cfc945-q52q5                1/1     Running            0               5m27s
pgsql-0                                        2/2     Running            0               5m27s
precise-code-intel-worker-56fcb8b568-dndfp     1/1     Running            1 (3m57s ago)   5m27s
precise-code-intel-worker-56fcb8b568-tlmw9     1/1     Running            1 (3m57s ago)   5m27s
prometheus-6f77c8b8c9-72msn                    1/1     Running            0               5m27s
redis-cache-85769b5b68-bmmxx                   2/2     Running            0               5m27s
redis-store-57fcc6bc75-49kfn                   2/2     Running            0               5m27s
repo-updater-56fc4cfd65-mtmzk                  1/1     Running            5 (4m12s ago)   5m27s
searcher-0                                     1/1     Running            0               5m27s
sourcegraph-frontend-75dcf95c75-2lprl          1/1     Running            0               5m27s
sourcegraph-frontend-75dcf95c75-rj8lg          1/1     Running            0               5m27s
symbols-0                                      1/1     Running            0               5m27s
syntactic-code-intel-worker-757d7bc48b-fb8vk   1/1     Running            0               4m33s
syntactic-code-intel-worker-757d7bc48b-h5h6l   1/1     Running            0               4m33s
syntect-server-7864888d76-56z5w                1/1     Running            0               5m27s
worker-85cfd4bc77-ght2z                        1/1     Running            1 (3m47s ago)   5m27s

Unit tests work as expected:

❯ helm unittest ./charts/sourcegraph/.

### Chart [ sourcegraph ] ./charts/sourcegraph/.

 PASS  affinity charts/sourcegraph/tests/affinity_test.yaml
 PASS  cadvisorPrivileged       charts/sourcegraph/tests/cadvisorPrivileged_test.yaml
 PASS  checksumTest     charts/sourcegraph/tests/checksum_test.yaml
 PASS  postgresAdditionalConfig charts/sourcegraph/tests/codeInsightsDBAdditionalConfig_test.yaml
 PASS  codeIntelDBAdditionalConfig      charts/sourcegraph/tests/codeIntelDBAdditionalConfig_test.yaml
 PASS  defaultTagPrefix charts/sourcegraph/tests/defaultTagPrefix_test.yaml
 PASS  localDevMode     charts/sourcegraph/tests/localDevMode_test.yaml
 PASS  nodeExporter     charts/sourcegraph/tests/nodeExporter_test.yaml
 PASS  otelAgentHostPort        charts/sourcegraph/tests/otelAgentHostPort_test.yaml
 PASS  otelCollectorJaeger      charts/sourcegraph/tests/otelCollectorJaeger_test.yaml
 PASS  pgsqlAdditionalConfig    charts/sourcegraph/tests/pgsqlAdditionalConfig_test.yaml
 PASS  pgsqlAuth        charts/sourcegraph/tests/pgsqlAuth_test.yaml
 PASS  podDisruptionBudget      charts/sourcegraph/tests/podDisruptionBudget_test.yaml
 PASS  priorityClass    charts/sourcegraph/tests/priorityClass_test.yaml
 PASS  prometheusPrivileged     charts/sourcegraph/tests/prometheusPrivileged_test.yaml
 PASS  serviceAccountAnnotations        charts/sourcegraph/tests/serviceAccountAnnotations_test.yaml
 PASS  serviceAccount   charts/sourcegraph/tests/serviceAccounts_test.yaml
 PASS  storageClass     charts/sourcegraph/tests/storageClass_test.yaml
 PASS  worker   charts/sourcegraph/tests/worker_test.yaml

Charts:      1 passed, 1 total
Test Suites: 19 passed, 19 total
Tests:       78 passed, 78 total
Snapshot:    12 passed, 12 total
Time:        1.3736565s

@antonsviridov-src antonsviridov-src merged commit 93ec7d9 into main Mar 6, 2025
7 checks passed
@antonsviridov-src antonsviridov-src deleted the antonsviridov-src-patch-1 branch March 6, 2025 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants