Skip to content

Conversation

@Chickensoupwithrice
Copy link
Contributor

@Chickensoupwithrice Chickensoupwithrice commented Jun 25, 2025

Since we're dependent on batch-changes for pr creation now (given it doesn't clone the .git files so we can't create PRs from execution phase) we have to modify the release.yaml. Instead of breaking existing workflows, we're creating a new release.yaml here eventually to be deprecated. I tested this yesterday on the docker repo, and it worked fine, so I'm replicating that here.

It's a direct copy of the release.yaml, except since it's in a subdir, it needs to change the directory sg ops update-images runs from. I also had to remove references to git and gh

Checklist

Test plan

Run batch change temporal workflow

@Chickensoupwithrice Chickensoupwithrice requested a review from a team June 25, 2025 23:03
@Chickensoupwithrice Chickensoupwithrice enabled auto-merge (squash) June 26, 2025 20:44
@Chickensoupwithrice Chickensoupwithrice force-pushed the al/add-batch-change-release.yaml branch from 8eaf8ca to e5b74ae Compare June 26, 2025 20:44
@Chickensoupwithrice Chickensoupwithrice merged commit 449e570 into main Jun 26, 2025
7 checks passed
@Chickensoupwithrice Chickensoupwithrice deleted the al/add-batch-change-release.yaml branch June 26, 2025 20:45
enriquegh pushed a commit that referenced this pull request Jul 10, 2025
Since we're dependent on batch-changes for pr creation now (given it
doesn't clone the .git files so we can't create PRs from execution
phase) we have to modify the release.yaml. Instead of breaking existing
workflows, we're creating a new release.yaml here eventually to be
deprecated. I tested this yesterday on the docker repo, and it worked
fine, so I'm replicating that here.

It's a direct copy of the `release.yaml`, except since it's in a subdir,
it needs to change the directory `sg ops update-images` runs from. I
also had to remove references to `git` and `gh`
### Checklist

- [ ] Follow the [manual testing
process](https://github.com/sourcegraph/deploy-sourcegraph-helm/blob/main/TEST.md)
- [ ] Update
[changelog](https://github.com/sourcegraph/deploy-sourcegraph-helm/blob/main/charts/sourcegraph/CHANGELOG.md)
- [ ] Update [Kubernetes update
doc](https://docs.sourcegraph.com/admin/updates/kubernetes)

### Test plan
Run batch change temporal workflow

<!--
As part of SOC2/GN-104 and SOC2/GN-105 requirements, all pull requests
are REQUIRED to
provide a "test plan". A test plan is a loose explanation of what you
have done or
implemented to test this, as outlined in our Testing principles and
guidelines:

https://docs.sourcegraph.com/dev/background-information/testing_principles
  Write your test plan here after the "Test plan" header.
-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants