Remove symbols statefulset #271
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starting in Sourcegraph 6.4, the Symbols and Searcher services are now combined, for easier operation, simplified architecture, and better resource utilization. Customers can delete the service if not deleted automatically, and may want to consider reallocating resources previously given to symbols to searcher. Environment variables should be copied over from symbols to searcher. Test plan: This deployment ran for ~2 weeks on S2 and dotcom already and has signoff from team-product-platform.
eseliger
commented
May 12, 2025
There was a problem hiding this comment.
this was in the symbols dir previously, and the symbols file was in searcher 😆
eseliger
commented
May 12, 2025
| - ReadWriteOnce | ||
| resources: | ||
| requests: | ||
| storage: 50G |
There was a problem hiding this comment.
seems like this never requested a specific storage class -- weird but I don't really want to change this now and cause deployment issues, wdyt?
There was a problem hiding this comment.
It's likely a mistake it never requested a storageClass to begin with 🙁
If we add it now though, K8s won't migrate the data (it won't delete it either), but the PVC would be recreated and be empty which would likely cause issue with our customers.
There was a problem hiding this comment.
right, that's why I was hesitant to add it 🙈
jdpleiness
approved these changes
May 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting in Sourcegraph 6.4, the Symbols and Searcher services are now combined, for easier operation, simplified architecture, and better resource utilization.
Customers can delete the service if not deleted automatically, and may want to consider reallocating resources previously given to symbols to searcher. Environment variables should be copied over from symbols to searcher.
Test plan: This deployment ran for ~2 weeks on S2 and dotcom already and has signoff from team-product-platform.
Checklist