Skip to content
This repository was archived by the owner on Jun 9, 2025. It is now read-only.

Conversation

@marcleblanc2
Copy link
Contributor

@marcleblanc2 marcleblanc2 commented Mar 25, 2025

Description

Linear issue REL-812: Update deployment types

Instances with deployment type "Kubernetes" are too vague to be useful in telemetry. Setting this now, so that we can start identifying these usefully in Telemetry as customers upgrade their legacy Kustomize instances >= 6.2.0

NOTE:

Checklist

Test plan

Test in Looker

@marcleblanc2 marcleblanc2 enabled auto-merge (squash) March 25, 2025 22:29
@marcleblanc2 marcleblanc2 disabled auto-merge March 25, 2025 23:14
@marcleblanc2 marcleblanc2 marked this pull request as draft March 25, 2025 23:15
@marcleblanc2 marcleblanc2 changed the title Add DEPLOY env var to legacy Kustomize repo so we can start identifying these in telemetry Add DEPLOY env var to legacy Kustomize so we can start identifying these in telemetry Mar 26, 2025
@marcleblanc2 marcleblanc2 changed the title Add DEPLOY env var to legacy Kustomize so we can start identifying these in telemetry Add DEPLOY_TYPE to legacy Kustomize so we can identify these in telemetry Mar 26, 2025
@marcleblanc2 marcleblanc2 marked this pull request as ready for review March 27, 2025 03:49
@marcleblanc2 marcleblanc2 changed the title Add DEPLOY_TYPE to legacy Kustomize so we can identify these in telemetry Chore: Fix deployment types in telemetry Mar 27, 2025
@marcleblanc2 marcleblanc2 merged commit ef0b0c8 into main Mar 27, 2025
29 of 30 checks passed
@marcleblanc2 marcleblanc2 deleted the marc/deploy-env-var branch March 27, 2025 03:54
@sourcegraph-release-bot
Copy link
Collaborator

The backport to 6.2.x failed at https://github.com/sourcegraph/deploy-sourcegraph/actions/runs/14183889559:

The process '/usr/bin/git' failed with exit code 128

To backport this PR manually, you can either:

Via the sg tool

Use the sg backport command to backport your commit to the release branch.

sg backport -r 6.2.x -p 4454
Via your terminal

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-6.2.x 6.2.x
# Navigate to the new working tree
cd .worktrees/backport-6.2.x
# Create a new branch
git switch --create backport-4454-to-6.2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 ef0b0c807e078d8eb3e9165f6661e0a19daad68a
# Push it to GitHub
git push --set-upstream origin backport-4454-to-6.2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-6.2.x

If you encouter conflict, first resolve the conflict and stage all files, then run the commands below:

git cherry-pick --continue
# Push it to GitHub
git push --set-upstream origin backport-4454-to-6.2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-6.2.x
  • Follow above instructions to backport the commit.
  • Create a pull request where the base branch is 6.2.x and the compare/head branch is backport-4454-to-6.2.x., click here to create the pull request.

Once the pull request has been created, please ensure the following:

  • Make sure to tag @sourcegraph/release in the pull request description.

  • kindly remove the release-blocker from this pull request.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants