Skip to content

Conversation

@peterguy
Copy link
Contributor

@peterguy peterguy commented Apr 2, 2025

Links to fragments (bookmarks) in batch-spec-yaml-reference were incorrect: they contained dashes where dots are in the headings, but the bookmark generator (GithubSlugger) creates ids by removing alpha-numeric characters and encoding spaces as dashes, so the links with dashes where there were dots didn't work.

Remove all dashes; spot test the links.

Also did some general fixup of batch-spec-yaml-reference links, where the dashes were underscores, and fixed a redirector that was directing to the wrong location.

Tacked on a similar fix in docs/admin/code_hosts/bitbucket_server.mdx

@vercel
Copy link

vercel bot commented Apr 2, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sourcegraph-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 8, 2025 8:21pm

@peterguy peterguy requested a review from MaedahBatool April 2, 2025 23:40
@peterguy peterguy marked this pull request as ready for review April 2, 2025 23:40
Copy link
Contributor

@MaedahBatool MaedahBatool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed the merge conflicts. Let's make it live.

@MaedahBatool MaedahBatool merged commit 22d46a0 into main May 8, 2025
5 checks passed
@MaedahBatool MaedahBatool deleted the peterguy/fix-fragment-links-in-batch-spec-yaml-reference branch May 8, 2025 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants