Skip to content

Conversation

@willdollman
Copy link
Contributor

@willdollman willdollman commented Oct 15, 2024

Add public-facing docs for fetching SBOMs using src.

Pull Request approval

Although pull request approval is not enforced for this repository in order to reduce friction, merging without a review will generate a ticket for the docs team to review your changes. So if possible, have your pull request approved before merging.

TODO

  • Add screenshot of version
  • Make it clear that you don't need to install before fetching SBOMs
  • Add successful output from command
  • Update version in examples after release

@willdollman willdollman self-assigned this Oct 15, 2024
@vercel
Copy link

vercel bot commented Oct 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sourcegraph-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 5, 2024 10:18am

@willdollman
Copy link
Contributor Author

willdollman commented Oct 15, 2024

@MaedahBatool the Vercel preview for this PR (and others) seems to be broken. Is this something we're aware of?

@willdollman can you please add /docs at the end of the preview URL it will work then. Also, are these docs SG version contingent?

Copy link
Contributor

@evict evict left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Contributor

@MaedahBatool MaedahBatool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MaedahBatool
Copy link
Contributor

@MaedahBatool the Vercel preview for this PR (and others) seems to be broken. Is this something we're aware of?

@willdollman can you please add /docs at the end of the preview URL it will work then. Also, are these docs SG version contingent?

hey @willdollman is the Vercel issue solved or still not working?

@willdollman
Copy link
Contributor Author

@MaedahBatool Yes, these changes only apply to 5.9 onwards so I was waiting until that release before merging - it was released yesterday so I can now merge. Is there anything special I need to do? The notion page is WIP https://www.notion.so/sourcegraph/Docs-Versioning-88d31f1e103343d2bdbc30a11595b384

Yes, the link works if you add /docs 👍 Can we fix the preview link?

Github doesn't send notifications if you edit someone's comment, so I only just saw your original message.

@willdollman willdollman merged commit f442218 into main Nov 5, 2024
5 checks passed
@willdollman willdollman deleted the will/sboms branch November 5, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants