Skip to content

Conversation

marcleblanc2
Copy link
Contributor

Updating from customer feedback.

Pull Request approval

You will need to get your PR approved by at least one member of the Sourcegraph team. For reviews of docs formatting, styles, and component usage, please tag the docs team via the #docs Slack channel.

Copy link

vercel bot commented Nov 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sourcegraph-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 5, 2024 6:27am

@marcleblanc2
Copy link
Contributor Author

@marcleblanc2
Copy link
Contributor Author

@michaellzc, does the tunnel server get deployed in the same VPC as the customer's SG Cloud instance, as per the Excalidraw diagram, or in its own VPC in its own GCP project, per the page's text content?

@marcleblanc2 marcleblanc2 disabled auto-merge November 5, 2024 04:48
@michaellzc
Copy link
Member

@michaellzc, does the tunnel server get deployed in the same VPC as the customer's SG Cloud instance, as per the Excalidraw diagram, or in its own VPC in its own GCP project, per the page's text content?

it's in the same dedicated VPC as the Cloud instance.

@marcleblanc2
Copy link
Contributor Author

it's in the same dedicated VPC as the Cloud instance.

Sounds good, I'll update the page content to match.

@marcleblanc2
Copy link
Contributor Author

@michaellzc do clients and agents use the same identity, or do clients have one identity and agents have a separate identity?

@michaellzc
Copy link
Member

@michaellzc do clients and agents use the same identity, or do clients have one identity and agents have a separate identity?

each instance of components have separate identities.

tunnel client for gitserver and tunnel client for frontend all use different identities

@MaedahBatool
Copy link
Contributor

hey @marcleblanc2 are we ready to merge this PR?

Copy link
Contributor

@MaedahBatool MaedahBatool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@MaedahBatool MaedahBatool merged commit 9b9b343 into main Jul 21, 2025
5 checks passed
@MaedahBatool MaedahBatool deleted the ml/update-private-connect-doc-page branch July 21, 2025 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants