6.0.0 MVU upgrade docs update #946

DaedalusG · 2025-02-03T05:14:46Z

This PR updates the upgrade docs embellishing instructions for the different deployment methods to include better coverage and handling of the Postgres 16 database upgrade when crossing over Sourcegraph 5.10.0 using migrator 6.0.0 or greater.

The notable change here is the inclusion of deployment specific builtin Postgres upgrade instructions, as well as changes to the MVU upgrade docs suggesting that users bring down all services and merge upstream changes from their target version into their release branch before performing their migrator upgrade. Due to migrators depends_on clause this will ensure that Postgres upgrades occur before migrator attempts connection to a PG12 database. This gets around the connect bouncer added in 6.0.0 which blocks services connection to our dbs

Testing

They should be "copy-pasteable" now. I put it in quotes because they have to paste it very specifically, but I think they are sufficiently idiot proof

vercel · 2025-02-03T05:14:51Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
sourcegraph-docs	🛑 Canceled (Inspect)			Feb 4, 2025 5:37pm

DaedalusG · 2025-02-03T10:16:51Z

This is a separate thing, but autoupgrade doesn't really work very well with k8s deployments

{"SeverityText":"WARN","Timestamp":1738577648562528772,"InstrumentationScope":"frontend","Caller":"cli/autoupgrade.go:282","Function":"github.com/sourcegraph/sourcegraph/cmd/frontend/internal/cli.claimAutoUpgradeLock","Body":"named postgres connections found, waiting for them to shutdown, manually shutdown any unexpected ones","Resource":{"service.name":"frontend","service.version":"6.0.0","service.instance.id":"sourcegraph-frontend-bc5dc56f5-t4ns2"},"Attributes":{"applications":["repo-updater"]}}
➜  deploy-sourcegraph-k8s git:(release) ✗ k get pods
NAME                                         READY   STATUS             RESTARTS        AGE
blobstore-776f6ff9d4-tbjk9                   1/1     Running            0               8m36s
codeinsights-db-0                            2/2     Running            0               8m36s
codeintel-db-0                               2/2     Running            0               8m36s
gitserver-0                                  0/1     CrashLoopBackOff   6 (16s ago)     8m36s
grafana-0                                    1/1     Running            0               8m36s
indexed-search-0                             2/2     Running            0               8m6s
node-exporter-8ch2b                          1/1     Running            0               8m37s
pgsql-0                                      2/2     Running            0               8m36s
precise-code-intel-worker-6b4469fcb8-h5bfs   0/1     CrashLoopBackOff   6 (2m17s ago)   8m37s
prometheus-564889b58c-qtd7h                  1/1     Running            0               8m36s
redis-cache-766c488dd8-4hw5n                 2/2     Running            0               8m36s
redis-store-868dc9bd4f-hmwvj                 2/2     Running            0               8m36s
repo-updater-866ddd54df-pkjq2                1/1     Running            6 (11m ago)     13m
repo-updater-df44f556f-fdt4h                 0/1     CrashLoopBackOff   6 (111s ago)    8m37s
searcher-0                                   1/1     Running            0               8m36s
sourcegraph-frontend-bc5dc56f5-hp8x9         1/1     Running            0               8m37s
sourcegraph-frontend-bc5dc56f5-t4ns2         1/1     Running            0               8m37s
symbols-0                                    0/1     Running            6 (2m55s ago)   8m36s
syntect-server-9ddff8b8d-225r2               1/1     Running            0               8m37s
worker-64c947c995-mb7fr                      0/1     CrashLoopBackOff   6 (116s ago)    8m37s

To fix this you'd need to go in and scale down the services that are continually trying to reach the DB

DaedalusG · 2025-02-03T10:49:23Z

Calling it for now but I suspect we'll have to special case Helm and add a note to the kubernetes upgrade notes saying that MVU for helm specifically can't got over the v5.10 boundary. I want to investigate packaging an override file that updates the images in the repo though

https://github.com/sourcegraph/deploy-sourcegraph-helm/blob/main/charts/sourcegraph/examples/basic/override.yaml

MaedahBatool

Left very minor comments.

docs/admin/deploy/docker-compose/upgrade.mdx

docs/admin/deploy/kubernetes/index.mdx

docs/admin/how-to/upgrade-postgres-12-16-builtin-dbs.mdx

Co-authored-by: Maedah Batool <[email protected]>

Chickensoupwithrice · 2025-02-04T00:13:25Z

docs/admin/deploy/docker-compose/upgrade.mdx

    migrator:
      container_name: migrator
-      image: 'index.docker.io/sourcegraph/migrator:5.0.4'
+      image: 'index.docker.io/sourcegraph/migrator:6.0.0'


we may want to use CURRENT_VERSION_STRING stuff here?

I'd be into doing this as a revision later yea, at the moment I think we just need to ship this, and a lot of SG uses this stuff

jdpleiness

A few spelling or grammar issues but nothing blocking in the docs content.

jdpleiness · 2025-02-04T16:20:00Z

docs/admin/deploy/docker-compose/upgrade.mdx

-    3. Run migrator with `docker-compose up migrator` **Example:**
+    3. Run migrator with `docker-compose up migrator` 
+
+    - Migrator `depends_on:` will ensure that the databases are ready before attempting to run migrator. Ensuring that database entrypoint scripts are run before migrator attempts to connect to the databases. For users upgrading from a version earliar than `5.10.0` a PostrgreSQL version is required and will be performed automatically here. For more details see [Upgradeing PostgreSQL](/admin/postgresql#upgrading-postgresql).


docs/admin/deploy/docker-compose/upgrade.mdx

docs/admin/how-to/upgrade-postgres-12-16-builtin-dbs.mdx

docs/admin/postgres.mdx

Co-authored-by: Jacob Pleiness <[email protected]>

MaedahBatool

Few fixes on format and syntax. Approving to unblock you.

docs/admin/deploy/kubernetes/index.mdx

docs/admin/deploy/docker-compose/upgrade.mdx

docs/admin/postgres.mdx

MaedahBatool · 2025-02-04T17:30:07Z

docs/admin/updates/kubernetes.mdx

 ## v6.0.0

 - Sourcegraph 6.0.0 no longer supports PostgreSQL 12, admins must upgrade to PostgreSQL 16. See our [postgres 12 end of life](/admin/postgres12_end_of_life_notice) notice! As well as [supporting documentation](/admin/postgres) and advisements on how to upgrade.
+- <Callout type="warning">The Kuberentes Helm deployment type does not support MVU from Sourcegraph `v5.9.45` versions and earlier to Sourcegraph `v6.0.0`. Admins seeking to upgrade to Sourcegraph `v6.0.0` should upgrade to `v5.11.6271` then use the standard upgrade procedure to get to `v6.0.0`. This is because migrator v6.0.0 will no longer connect to Postgres 12 databases. For more info see our [PostgreSQL upgrade docs](/admin/postgres#requirements).</Callout>


Suggested change

- <Callout type="warning">The Kuberentes Helm deployment type does not support MVU from Sourcegraph `v5.9.45` versions and earlier to Sourcegraph `v6.0.0`. Admins seeking to upgrade to Sourcegraph `v6.0.0` should upgrade to `v5.11.6271` then use the standard upgrade procedure to get to `v6.0.0`. This is because migrator v6.0.0 will no longer connect to Postgres 12 databases. For more info see our [PostgreSQL upgrade docs](/admin/postgres#requirements).</Callout>

- <Callout type="warning">The Kubernetes Helm deployment type does not support MVU from Sourcegraph `v5.9.45` versions and earlier to Sourcegraph `v6.0.0`. Admins seeking to upgrade to Sourcegraph `v6.0.0` should upgrade to `v5.11.6271` and then use the standard upgrade procedure to get to `v6.0.0`. This is because migrator v6.0.0 will no longer connect to Postgres 12 databases. For more info see our [PostgreSQL upgrade docs](/admin/postgres#requirements).</Callout>

DaedalusG and others added 6 commits January 31, 2025 11:52

additional note

46b7841

feat: add upgrade guide for 6.0

a260768

fix: update upgrade docs for PG16 docker-compose

fae5c96

They should be "copy-pasteable" now. I put it in quotes because they have to paste it very specifically, but I think they are sufficiently idiot proof

fix: add copy-paste commands for k8s upgrade

b144cc0

docker-compose updates

4440ca6

docker-compose formating edits

2952920

DaedalusG mentioned this pull request Feb 3, 2025

Revision to migrator upgrade runbook to call our PG16 upgrade #945

Closed

remove unneeded special case docker-compose upgrade doc

84ee836

vercel bot deployed to Preview February 3, 2025 09:45 View deployment

DaedalusG added 2 commits February 3, 2025 02:25

6.0.0 kustomize update

0eb5fee

slight edit to kustomize doc

bc25b93

vercel bot deployed to Preview February 3, 2025 10:31 View deployment

MaedahBatool suggested changes Feb 3, 2025

View reviewed changes

docs/admin/deploy/docker-compose/upgrade.mdx Outdated Show resolved Hide resolved

docs/admin/deploy/kubernetes/index.mdx Outdated Show resolved Hide resolved

docs/admin/how-to/upgrade-postgres-12-16-builtin-dbs.mdx Show resolved Hide resolved

DaedalusG requested a review from a team February 3, 2025 21:38

DaedalusG and others added 3 commits February 3, 2025 13:57

Update docs/admin/deploy/docker-compose/upgrade.mdx

7897d10

Co-authored-by: Maedah Batool <[email protected]>

Update docs/admin/deploy/kubernetes/index.mdx

4d992b2

Co-authored-by: Maedah Batool <[email protected]>

Merge branch 'main' into wg/rel/sourcegraph-6-upgrade-docs

0ef56b1

vercel bot deployed to Preview February 3, 2025 22:07 View deployment

Chickensoupwithrice approved these changes Feb 3, 2025

View reviewed changes

helm special notes and edits

6f51f57

DaedalusG requested review from MaedahBatool, jdpleiness, loujar and marcleblanc2 February 4, 2025 00:03

vercel bot deployed to Preview February 4, 2025 00:07 View deployment

Chickensoupwithrice reviewed Feb 4, 2025

View reviewed changes

jdpleiness approved these changes Feb 4, 2025

View reviewed changes

DaedalusG and others added 6 commits February 4, 2025 09:14

Update docs/admin/deploy/docker-compose/upgrade.mdx

b8a05b9

Co-authored-by: Jacob Pleiness <[email protected]>

Update docs/admin/how-to/upgrade-postgres-12-16-builtin-dbs.mdx

f882b71

Co-authored-by: Jacob Pleiness <[email protected]>

Update docs/admin/how-to/upgrade-postgres-12-16-builtin-dbs.mdx

56b10c5

Co-authored-by: Jacob Pleiness <[email protected]>

Update docs/admin/postgres.mdx

099bf53

Co-authored-by: Jacob Pleiness <[email protected]>

Update docs/admin/how-to/upgrade-postgres-12-16-builtin-dbs.mdx

9412f04

Co-authored-by: Jacob Pleiness <[email protected]>

Merge branch 'main' into wg/rel/sourcegraph-6-upgrade-docs

c5cb8b6

vercel bot deployed to Preview February 4, 2025 17:21 View deployment

MaedahBatool approved these changes Feb 4, 2025

View reviewed changes

MaedahBatool added 4 commits February 4, 2025 09:30

Update docs/admin/deploy/kubernetes/index.mdx

6e45317

Update docs/admin/deploy/docker-compose/upgrade.mdx

2518380

Update docs/admin/postgres.mdx

5636e26

Update docs/admin/postgres.mdx

ff55146

DaedalusG merged commit 63790c5 into main Feb 4, 2025
4 of 5 checks passed

DaedalusG deleted the wg/rel/sourcegraph-6-upgrade-docs branch February 4, 2025 17:32

vercel bot deployed to Preview February 4, 2025 17:37 View deployment

6.0.0 MVU upgrade docs update #946

6.0.0 MVU upgrade docs update #946

Uh oh!

Conversation

DaedalusG commented Feb 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Testing

Uh oh!

vercel bot commented Feb 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

DaedalusG commented Feb 3, 2025

Uh oh!

DaedalusG commented Feb 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MaedahBatool left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Chickensoupwithrice Feb 4, 2025

Choose a reason for hiding this comment

Uh oh!

DaedalusG Feb 4, 2025

Choose a reason for hiding this comment

Uh oh!

jdpleiness left a comment

Choose a reason for hiding this comment

Uh oh!

jdpleiness Feb 4, 2025

Choose a reason for hiding this comment

Uh oh!

jdpleiness Feb 4, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

MaedahBatool left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

MaedahBatool Feb 4, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

DaedalusG commented Feb 3, 2025 •

edited

Loading

vercel bot commented Feb 3, 2025 •

edited

Loading

DaedalusG commented Feb 3, 2025 •

edited

Loading