continue emitting refs for 'this' constructor calls

Author: Strum355

semanticdb-javac/src/main/java/com/sourcegraph/semanticdb_javac/SemanticdbVisitor.java

@@ -13,6 +13,7 @@
 import com.sourcegraph.semanticdb_javac.Semanticdb.SymbolInformation.Property;
 import com.sourcegraph.semanticdb_javac.Semanticdb.SymbolOccurrence.Role;
 
+import javax.lang.model.element.ElementKind;
 import javax.lang.model.util.Elements;
 import java.io.IOException;
 import java.nio.file.Path;
@@ -193,7 +194,8 @@ public Void visitVariable(VariableTree node, Void unused) {
   public Void visitIdentifier(IdentifierTree node, Void unused) {
     if (node instanceof JCTree.JCIdent) {
       JCTree.JCIdent ident = (JCTree.JCIdent) node;
-      if (ident.name.toString().equals("this")) return null;
+      if (ident.name.toString().equals("this") && ident.sym.getKind() != ElementKind.CONSTRUCTOR)
+        return null;
       emitSymbolOccurrence(ident.sym, ident, Role.REFERENCE, CompilerRange.FROM_START_TO_END);
     }
     return super.visitIdentifier(node, unused);

tests/snapshots/src/main/generated/com/airbnb/epoxy/AsyncEpoxyController.java

@@ -32,6 +32,7 @@ public abstract class AsyncEpoxyController extends EpoxyController {
   public AsyncEpoxyController() {
 //       ^^^^^^^^^^^^^^^^^^^^ definition com/airbnb/epoxy/AsyncEpoxyController#`<init>`(). public AsyncEpoxyController()
     this(true);
+//  ^^^^ reference com/airbnb/epoxy/AsyncEpoxyController#`<init>`(+1).
   }
 
   /**
@@ -42,6 +43,7 @@ public AsyncEpoxyController(boolean enableAsync) {
 //       ^^^^^^^^^^^^^^^^^^^^ definition com/airbnb/epoxy/AsyncEpoxyController#`<init>`(+1). public AsyncEpoxyController(boolean enableAsync)
 //                                    ^^^^^^^^^^^ definition local0 boolean enableAsync
     this(enableAsync, enableAsync);
+//  ^^^^ reference com/airbnb/epoxy/AsyncEpoxyController#`<init>`(+2).
 //       ^^^^^^^^^^^ reference local0
 //                    ^^^^^^^^^^^ reference local0
   }

tests/snapshots/src/main/generated/com/airbnb/epoxy/Carousel.java

@@ -947,6 +947,7 @@ public Padding(@Px int paddingPx, @Px int itemSpacingPx) {
 //                                     ^^ reference androidx/annotation/Px#
 //                                            ^^^^^^^^^^^^^ definition local53 @Px int itemSpacingPx
       this(paddingPx, paddingPx, paddingPx, paddingPx, itemSpacingPx, PaddingType.PX);
+//    ^^^^ reference com/airbnb/epoxy/Carousel#Padding#`<init>`(+2).
 //         ^^^^^^^^^ reference local52
 //                    ^^^^^^^^^ reference local52
 //                               ^^^^^^^^^ reference local52
@@ -978,6 +979,7 @@ public Padding(
 //                                                                         ^^ reference androidx/annotation/Px#
 //                                                                                ^^^^^^^^^^^^^ definition local58 @Px int itemSpacingPx
       this(leftPx, topPx, rightPx, bottomPx, itemSpacingPx, PaddingType.PX);
+//    ^^^^ reference com/airbnb/epoxy/Carousel#Padding#`<init>`(+2).
 //         ^^^^^^ reference local54
 //                 ^^^^^ reference local55
 //                        ^^^^^^^ reference local56

tests/snapshots/src/main/generated/com/airbnb/epoxy/DiffPayload.java

@@ -90,6 +90,7 @@ public DiffPayload(EpoxyModel<?> changedItem) {
 //                   ^^^^^^^^^^ reference com/airbnb/epoxy/EpoxyModel#
 //                                 ^^^^^^^^^^^ definition local3 EpoxyModel<?> changedItem
     this(Collections.singletonList(changedItem));
+//  ^^^^ reference com/airbnb/epoxy/DiffPayload#`<init>`().
 //       ^^^^^^^^^^^ reference java/util/Collections#
 //                   ^^^^^^^^^^^^^ reference java/util/Collections#singletonList().
 //                                 ^^^^^^^^^^^ reference local3

tests/snapshots/src/main/generated/com/airbnb/epoxy/EpoxyController.java

@@ -223,6 +223,7 @@ public abstract class EpoxyController implements ModelCollector, StickyHeaderCal
   public EpoxyController() {
 //       ^^^^^^^^^^^^^^^ definition com/airbnb/epoxy/EpoxyController#`<init>`(). public EpoxyController()
     this(defaultModelBuildingHandler, defaultDiffingHandler);
+//  ^^^^ reference com/airbnb/epoxy/EpoxyController#`<init>`(+1).
 //       ^^^^^^^^^^^^^^^^^^^^^^^^^^^ reference com/airbnb/epoxy/EpoxyController#defaultModelBuildingHandler.
 //                                    ^^^^^^^^^^^^^^^^^^^^^ reference com/airbnb/epoxy/EpoxyController#defaultDiffingHandler.
   }

tests/snapshots/src/main/generated/com/airbnb/epoxy/EpoxyHolder.java

@@ -27,6 +27,7 @@ public EpoxyHolder(@NonNull ViewParent parent) {
 //                            ^^^^^^^^^^ reference _root_/
 //                                       ^^^^^^ definition local0 @NonNull unresolved_type parent
     this();
+//  ^^^^ reference com/airbnb/epoxy/EpoxyHolder#`<init>`(+1).
   }
 
   public EpoxyHolder() {

tests/snapshots/src/main/generated/com/airbnb/epoxy/EpoxyItemSpacingDecorator.java

@@ -85,6 +85,7 @@ public class EpoxyItemSpacingDecorator extends RecyclerView.ItemDecoration {
   public EpoxyItemSpacingDecorator() {
 //       ^^^^^^^^^^^^^^^^^^^^^^^^^ definition com/airbnb/epoxy/EpoxyItemSpacingDecorator#`<init>`(). public EpoxyItemSpacingDecorator()
     this(0);
+//  ^^^^ reference com/airbnb/epoxy/EpoxyItemSpacingDecorator#`<init>`(+1).
   }
 
   public EpoxyItemSpacingDecorator(@Px int pxBetweenItems) {

tests/snapshots/src/main/generated/com/airbnb/epoxy/EpoxyModel.java

@@ -138,6 +138,7 @@ protected EpoxyModel(long id) {
   public EpoxyModel() {
 //       ^^^^^^^^^^ definition com/airbnb/epoxy/EpoxyModel#`<init>`(+1). public EpoxyModel()
     this(idCounter--);
+//  ^^^^ reference com/airbnb/epoxy/EpoxyModel#`<init>`().
 //       ^^^^^^^^^ reference com/airbnb/epoxy/EpoxyModel#idCounter.
     hasDefaultId = true;
 //  ^^^^^^^^^^^^ reference com/airbnb/epoxy/EpoxyModel#hasDefaultId.

tests/snapshots/src/main/generated/com/airbnb/epoxy/EpoxyModelGroup.java

@@ -127,6 +127,7 @@ public EpoxyModelGroup(@LayoutRes int layoutRes, Collection<? extends EpoxyModel
 //                                                                      ^^^^^^^^^^ reference com/airbnb/epoxy/EpoxyModel#
 //                                                                                     ^^^^^^ definition local1 Collection<? extends EpoxyModel<?>> models
     this(layoutRes, new ArrayList<>(models));
+//  ^^^^ reference com/airbnb/epoxy/EpoxyModelGroup#`<init>`(+2).
 //       ^^^^^^^^^ reference local0
 //                      ^^^^^^^^^ reference java/util/ArrayList#`<init>`(+2).
 //                                  ^^^^^^ reference local1
@@ -143,6 +144,7 @@ public EpoxyModelGroup(@LayoutRes int layoutRes, EpoxyModel<?>... models) {
 //                                                 ^^^^^^^^^^ reference com/airbnb/epoxy/EpoxyModel#
 //                                                                  ^^^^^^ definition local3 EpoxyModel<?>[] models
     this(layoutRes, new ArrayList<>(Arrays.asList(models)));
+//  ^^^^ reference com/airbnb/epoxy/EpoxyModelGroup#`<init>`(+2).
 //       ^^^^^^^^^ reference local2
 //                      ^^^^^^^^^ reference java/util/ArrayList#`<init>`(+2).
 //                                  ^^^^^^ reference java/util/Arrays#
@@ -220,6 +222,7 @@ protected EpoxyModelGroup(@LayoutRes int layoutRes) {
 //                           ^^^^^^^^^ reference androidx/annotation/LayoutRes#
 //                                         ^^^^^^^^^ definition local8 @LayoutRes int layoutRes
     this();
+//  ^^^^ reference com/airbnb/epoxy/EpoxyModelGroup#`<init>`(+3).
     layout(layoutRes);
 //  ^^^^^^ reference com/airbnb/epoxy/EpoxyModel#layout().
 //         ^^^^^^^^^ reference local8

tests/snapshots/src/main/generated/com/airbnb/epoxy/ImmutableModelException.java

@@ -28,6 +28,7 @@ class ImmutableModelException extends RuntimeException {
 //                                   ^^^^^ definition local0 EpoxyModel model
 //                                              ^^^^^^^^^^^^^ definition local1 int modelPosition
     this(model, "", modelPosition);
+//  ^^^^ reference com/airbnb/epoxy/ImmutableModelException#`<init>`(+1).
 //       ^^^^^ reference local0
 //                  ^^^^^^^^^^^^^ reference local1
   }