Disallow SAT in clientcredentials middleware #101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: ᴊᴏᴇ ᴄʜᴇɴ <[email protected]>
unknwon
approved these changes
Jul 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SAMS Service Access Tokens function similarly to M2M tokens. Both use the same introspectToken call to SAMS. For SATs the response includes the user the token is scoped to.
In the case where a SAT and M2M token both have the same scopes we need to prevent privilege escalation where a SAT could be supplied to a M2M RPC which would not be expected to properly enforce the user scoping.
This PR updates the client credentials middleware to fail the request if an introspected token as a non-empty user field.
Closes CORE-1126
Test plan
CI