feat(releaseoperations): add service and roles #104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobheadxi
reviewed
Aug 27, 2025
| SSC Service = "ssc" | ||
| Analytics Service = "analytics" | ||
| CloudAPI Service = "cloud_api" | ||
| ReleaseOperations Service = "releaseoperations" |
Member
There was a problem hiding this comment.
Would release_operations be more in line with the existing services?
Contributor
Author
There was a problem hiding this comment.
This matches the other release services, which started with releaseregistry. I know it's kind of against the format for everything else, but at this point we kind of have our own standard on the release stuff for better or worse.
Member
There was a problem hiding this comment.
I think in this case you should follow the SAMS SDK convention 🙏 It doesn't affect your existing naming elsewhere
bobheadxi
approved these changes
Aug 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ReleaseOperations - add service and roles to accounts SDK
Test plan
Unit tests