clients/v1: Remove DeleteUser RPC from UsersService

[kalanchan]

part of CORE-1195: SAMS: remove DeleterUser endpoint from clientsv1, and user management RPC, and addressing @unknwon's comment

We initially implemented the DeleteUser RPC to handle all CRUD user management actions in the Enterprise Portal, but since then we have decided not to implement any deletion functionality in Enterprise Portal. To clean up the UsersService API, removing this to avoid managing 2 separate DeleteUser implementations.

Thanks to DeepSearch, this should be safe to remove as there are no downstream calls to the DeleteUser RPC

Test plan

CI

[unknwon]

Thanks for cleaning things up, but you sure you actually read the DeepSearch thread you linked? It clearly says there is one downstream call site: https://sourcegraph.sourcegraph.app/search?q=context:global+repo:%5Egithub%5C.com/sourcegraph/sourcegraph%24+users().DeleteUser&patternType=literal

We need to remove that call site first.

[unknwon]

Request changes because we need to remove the call site that uses this method.

[kalanchan]

Thanks for cleaning things up, but you sure you actually read the DeepSearch thread you linked? It clearly says there is one downstream call site: https://sourcegraph.sourcegraph.app/search?q=context:global+repo:%5Egithub%5C.com/sourcegraph/sourcegraph%24+users().DeleteUser&patternType=literal

We need to remove that call site first.

@unknwon it's technically not being used though, there aren't any handlers calling store.DeleteSAMSUser(). I was going to remove that in a follow up after this.

Do you still recommend deleting that first before merging this?

[unknwon]

Do you still recommend deleting that first before merging this?

Yes. BTW I think that's a requirement, not a recommendation, FWIW.

[kalanchan]

Do you still recommend deleting that first before merging this?

Yes. BTW I think that's a requirement, not a recommendation, FWIW.

fine! understood, will do 🫡

[kalanchan]

joe please stamp

[kalanchan]

@unknwon callsites have been removed in #6809, hurry up and please stamp!

[unknwon]

@unknwon callsites have been removed in #6809, hurry up and please stamp!

I'm regret to inform you that your auto-stamp status has not been earned.

[unknwon]

🚀

[kalanchan]

@unknwon callsites have been removed in #6809, hurry up and please stamp!

I'm regret to inform you that your auto-stamp status has not been earned.

How do I earn the auto-stamp status? can I be placed in a program?

[unknwon]

@unknwon callsites have been removed in #6809, hurry up and please stamp!

I'm regret to inform you that your auto-stamp status has not been earned.

How do I earn the auto-stamp status? can I be placed in a program?

First of all, do all of the follow ups.