This repository was archived by the owner on Sep 30, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
gqltest: Ensure fusion test is actually cloning depot #44539
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2209940 to
75ff1bf
Compare
Contributor
Author
|
Integration tests running here: |
Contributor
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff cc7bd73...75ff1bf.
|
Contributor
Author
|
Once this is merged we should merge main back into https://github.com/sourcegraph/sourcegraph/pull/44301 and confirm that the new version can also clone a depot. |
mrnugget
reviewed
Nov 17, 2022
Contributor
Author
|
@mrnugget PTAL |
mrnugget
approved these changes
Nov 17, 2022
Contributor
|
@cla-bot check |
|
The GitHub CLA Bot is rechecking to see that you have signed the CLA - note that it may take up to 30 minutes for your response to be synchronized. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous tests we not testing cloning via
p4-fusion, the following was happening:git p4test runs, completes and deletes external service which then softdeletes repo.
p4-fusioncan't find repo to delete since it's name has changedso does nothing. Repo is still on disk so we end up fetching rather than
cloning. Even if that fails, we still find the repo on disk and mark the test
as passed.
To fix this we now:
The tests were also refactored to make things a little more explicit.
Test plan
Tested many times locally, confirm that passed integration tests in CI.
Also manually changes code locally so that the
p4-fusioncommand would failto confirm we were actually running it.
Part of https://github.com/sourcegraph/sourcegraph/pull/44301