Skip to content

Keep Instruction additional data out of band in the Template#657

Merged
jviotti merged 1 commit intomainfrom
metadata-array
Mar 13, 2026
Merged

Keep Instruction additional data out of band in the Template#657
jviotti merged 1 commit intomainfrom
metadata-array

Conversation

@jviotti
Copy link
Member

@jviotti jviotti commented Mar 11, 2026

Signed-off-by: Juan Cruz Viotti jv@jviotti.com

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (linux/llvm)

Details
Benchmark suite Current: b8a364a Previous: a5ceb92 Ratio
E2E_Compiler_adaptivecard 59859572.5999985 ns/iter 64477641.77777217 ns/iter 0.93
E2E_Compiler_ansible_meta 23834011.888892647 ns/iter 27247033.600001488 ns/iter 0.87
E2E_Compiler_aws_cdk 313209.9373040398 ns/iter 349646.52071889734 ns/iter 0.90
E2E_Compiler_babelrc 2167863.377300339 ns/iter 2418247.137931193 ns/iter 0.90
E2E_Compiler_clang_format 15208604.086959222 ns/iter 17174689.12195217 ns/iter 0.89
E2E_Compiler_cmake_presets 23365764.533332366 ns/iter 25037307.142854713 ns/iter 0.93
E2E_Compiler_code_climate 2151769.598159134 ns/iter 2407579.7697597 ns/iter 0.89
E2E_Compiler_cql2 11821792.406782167 ns/iter 12692506.290909477 ns/iter 0.93
E2E_Compiler_cspell 21453827.970590815 ns/iter 22219329.12903324 ns/iter 0.97
E2E_Compiler_cypress 3415183.009755998 ns/iter 3811927.983606388 ns/iter 0.90
E2E_Compiler_deno 6260259.841119733 ns/iter 7342179.608247899 ns/iter 0.85
E2E_Compiler_dependabot 3194012.8761465983 ns/iter 3629579.274611222 ns/iter 0.88
E2E_Compiler_draft_04 2282620.950657887 ns/iter 2525696.8953069258 ns/iter 0.90
E2E_Compiler_fabric_mod 4005605.936781806 ns/iter 4493651.884614972 ns/iter 0.89
E2E_Compiler_geojson 19535019.416663446 ns/iter 20910681.93939202 ns/iter 0.93
E2E_Compiler_gitpod_configuration 4108705.5529420893 ns/iter 4620054.728477212 ns/iter 0.89
E2E_Compiler_helm_chart_lock 580274.4416326518 ns/iter 654919.4069223898 ns/iter 0.89
E2E_Compiler_importmap 238219.1522184465 ns/iter 267174.0383288886 ns/iter 0.89
E2E_Compiler_jasmine 1142222.1091205422 ns/iter 1270906.8943532775 ns/iter 0.90
E2E_Compiler_jshintrc 3552670.410257027 ns/iter 4119379.0294113676 ns/iter 0.86
E2E_Compiler_jsconfig 17893604.66666669 ns/iter 20462107.058823917 ns/iter 0.87
E2E_Compiler_krakend 124260529.16669051 ns/iter 135006158.99999958 ns/iter 0.92
E2E_Compiler_lazygit 28734073.50000434 ns/iter 31457300.454545394 ns/iter 0.91
E2E_Compiler_lerna 1332375.3973384663 ns/iter 1491105.2970084215 ns/iter 0.89
E2E_Compiler_nest_cli 6163348.070175377 ns/iter 6968325.8700001715 ns/iter 0.88
E2E_Compiler_omc 145771571.8000145 ns/iter 148604660.50001264 ns/iter 0.98
E2E_Compiler_omnisharp 5433630.550387463 ns/iter 6275127.982142692 ns/iter 0.87
E2E_Compiler_openapi 21548619.687500548 ns/iter 23607784.06666668 ns/iter 0.91
E2E_Compiler_pre_commit_hooks 4412272.48101273 ns/iter 5015754.070000185 ns/iter 0.88
E2E_Compiler_pulumi 3406758.5582525036 ns/iter 3798160.902702703 ns/iter 0.90
E2E_Compiler_semantic_release 1337439.1145040996 ns/iter 1464374.7949790568 ns/iter 0.91
E2E_Compiler_stale 1293840.5959412328 ns/iter 1453854.481404977 ns/iter 0.89
E2E_Compiler_stylecop 4700194.496645786 ns/iter 5570491.608000339 ns/iter 0.84
E2E_Compiler_tmuxinator 1613135.5046085368 ns/iter 1850403.4046389316 ns/iter 0.87
E2E_Compiler_ui5 43427111.56249379 ns/iter 46604051.799999975 ns/iter 0.93
E2E_Compiler_ui5_manifest 288594424.5000473 ns/iter 312060676.99997675 ns/iter 0.92
E2E_Compiler_unreal_engine_uproject 3801910.0163044482 ns/iter 4291094.441717797 ns/iter 0.89
E2E_Compiler_vercel 11062369.555554416 ns/iter 12186705.719298977 ns/iter 0.91
E2E_Compiler_yamllint 296944.83756345435 ns/iter 325460.447761191 ns/iter 0.91
E2E_Evaluator_adaptivecard 22569.72811521868 ns/iter 25517.819840744327 ns/iter 0.88
E2E_Evaluator_ansible_meta 210674.53693696146 ns/iter 235956.73328943137 ns/iter 0.89
E2E_Evaluator_aws_cdk 45734.70493957343 ns/iter 52152.18838942936 ns/iter 0.88
E2E_Evaluator_babelrc 96779.17425412146 ns/iter 110402.61119873528 ns/iter 0.88
E2E_Evaluator_cerebrum_criminal_case 1348928.6300578313 ns/iter 1297327.6120527019 ns/iter 1.04
E2E_Evaluator_clang_format 119389.29849471479 ns/iter 126509.66983546091 ns/iter 0.94
E2E_Evaluator_cmake_presets 4729078.691780908 ns/iter 4199539.958083781 ns/iter 1.13
E2E_Evaluator_code_climate 180705.54540751985 ns/iter 179377.70648289233 ns/iter 1.01
E2E_Evaluator_cql2 187288.11417850293 ns/iter 206225.9543042605 ns/iter 0.91
E2E_Evaluator_cspell 554706.5466878773 ns/iter 559736.5777598656 ns/iter 0.99
E2E_Evaluator_cypress 181867.42868280603 ns/iter 194335.7846582839 ns/iter 0.94
E2E_Evaluator_deno 324377.7492983519 ns/iter 324198.66021205223 ns/iter 1.00
E2E_Evaluator_dependabot 431364.4090068203 ns/iter 429617.1159684141 ns/iter 1.00
E2E_Evaluator_draft_04 8219785.643679392 ns/iter 7565568.921349081 ns/iter 1.09
E2E_Evaluator_fabric_mod 681482.6175025592 ns/iter 698062.3939394911 ns/iter 0.98
E2E_Evaluator_geojson 17033433.53658677 ns/iter 15753603.444444606 ns/iter 1.08
E2E_Evaluator_gitpod_configuration 237416.72107226274 ns/iter 233992.99565508112 ns/iter 1.01
E2E_Evaluator_helm_chart_lock 392453.17366624676 ns/iter 364801.9711134497 ns/iter 1.08
E2E_Evaluator_importmap 38102.350647916515 ns/iter 50655.34757155214 ns/iter 0.75
E2E_Evaluator_jasmine 100963.45666664527 ns/iter 107182.57745173588 ns/iter 0.94
E2E_Evaluator_jshintrc 1156047.3841062512 ns/iter 1213470.5503472374 ns/iter 0.95
E2E_Evaluator_jsconfig 386192.046434601 ns/iter 430944.2143294992 ns/iter 0.90
E2E_Evaluator_krakend 203686.04978036086 ns/iter 223023.14502094712 ns/iter 0.91
E2E_Evaluator_lazygit 132822.79798746522 ns/iter 150235.4361492938 ns/iter 0.88
E2E_Evaluator_lerna 147909.9966072789 ns/iter 151330.67555363823 ns/iter 0.98
E2E_Evaluator_nest_cli 186089.5840234887 ns/iter 187525.06962884674 ns/iter 0.99
E2E_Evaluator_omc 19010.343137515592 ns/iter 20801.512884773616 ns/iter 0.91
E2E_Evaluator_omnisharp 561201.0556003037 ns/iter 618939.8880995134 ns/iter 0.91
E2E_Evaluator_openapi 15049178.586957129 ns/iter 15171962.869564356 ns/iter 0.99
E2E_Evaluator_pre_commit_hooks 503936.41034978436 ns/iter 479940.8260274124 ns/iter 1.05
E2E_Evaluator_pulumi 748858.4657536525 ns/iter 714628.1545363114 ns/iter 1.05
E2E_Evaluator_semantic_release 87868.50682483819 ns/iter 102328.96869972181 ns/iter 0.86
E2E_Evaluator_stale 145861.69158289774 ns/iter 154501.37820091622 ns/iter 0.94
E2E_Evaluator_stylecop 288306.96375620365 ns/iter 291345.5806182395 ns/iter 0.99
E2E_Evaluator_tmuxinator 84909.84135431133 ns/iter 96651.33430271404 ns/iter 0.88
E2E_Evaluator_ui5 484369.6263812681 ns/iter 518727.6440803959 ns/iter 0.93
E2E_Evaluator_ui5_manifest 2620205.4777333266 ns/iter 2578733.970803078 ns/iter 1.02
E2E_Evaluator_unreal_engine_uproject 455252.70614311215 ns/iter 446820.3776493553 ns/iter 1.02
E2E_Evaluator_vercel 340547.1047803693 ns/iter 317461.19340263127 ns/iter 1.07
E2E_Evaluator_yamllint 9744.431463343231 ns/iter 10875.065870793545 ns/iter 0.90
Micro_Draft4_Meta_1_No_Callback 203.9975968571575 ns/iter 186.25309149520544 ns/iter 1.10
Micro_Draft4_Required_Properties 841.6879556274006 ns/iter 809.9014040498528 ns/iter 1.04
Micro_Draft4_Many_Optional_Properties_Minimal_Match 27.0716410595602 ns/iter 24.52134505741097 ns/iter 1.10
Micro_Draft4_Few_Optional_Properties_Minimal_Match 12.339655816464562 ns/iter 13.689920889885737 ns/iter 0.90
Micro_Draft4_Items_Schema 251.9323554383281 ns/iter 288.4808331493144 ns/iter 0.87
Micro_Draft4_Nested_Object 3.2243646810680717 ns/iter 3.7362531913006265 ns/iter 0.86
Micro_Draft4_Properties_Triad_Optional 346.83763906729223 ns/iter 348.7353196381361 ns/iter 0.99
Micro_Draft4_Properties_Triad_Closed 289.4847553824389 ns/iter 287.70414089281047 ns/iter 1.01
Micro_Draft4_Properties_Triad_Required 363.2704491529244 ns/iter 361.49882992061663 ns/iter 1.00
Micro_Draft4_Properties_Closed 59.778078100582746 ns/iter 59.21980079065559 ns/iter 1.01
Micro_Draft4_Non_Recursive_Ref 11.296519332527 ns/iter 13.936968423342057 ns/iter 0.81
Micro_Draft4_Pattern_Properties_True 198.27864758328565 ns/iter 229.57114447420687 ns/iter 0.86
Micro_Draft4_Ref_To_Single_Property 12.328723489922517 ns/iter 13.68966316070886 ns/iter 0.90
Micro_Draft4_Additional_Properties_Type 20.049441122727067 ns/iter 23.126235263479543 ns/iter 0.87
Micro_Draft4_Nested_Oneof 46.5330855410958 ns/iter 59.247922195122165 ns/iter 0.79
Micro_Draft4_Short_Enum 12.311808450015768 ns/iter 13.21693562745785 ns/iter 0.93
Micro_Draft4_Long_Enum 12.931907773287923 ns/iter 16.51203133660671 ns/iter 0.78
Micro_Draft4_Long_Enum_Short_Strings 12.259643658940373 ns/iter 13.083468840336034 ns/iter 0.94
Micro_Draft4_Type_Object 5.262406585930778 ns/iter 5.911374273792428 ns/iter 0.89
Micro_Draft4_Ref_Single_100 2076688.875000005 ns/iter 2338870.2775918376 ns/iter 0.89
Micro_Draft4_Compile_Ref_Many_Nested 1522841.2735228846 ns/iter 1696176.8140095156 ns/iter 0.90
Micro_Draft4_Compile_Wrap 2084714.2925375202 ns/iter 2312175.4488446377 ns/iter 0.90
Micro_Draft6_Property_Names 120.45550656396507 ns/iter 136.6285610405515 ns/iter 0.88
Micro_Draft6_Compile_FHIR 18598031792.99979 ns/iter 13861054108.000076 ns/iter 1.34
Micro_Draft7_If_Then_Else 23.169060516398115 ns/iter 26.46525041244841 ns/iter 0.88
Micro_2019_09_Unevaluated_Properties 30.831997200729294 ns/iter 38.97686707133267 ns/iter 0.79
Micro_2019_09_Compile_Wrap 269108461.666671 ns/iter 284678084.0000065 ns/iter 0.95
Micro_2019_09_KrakenD_Linter_Check 1366681758.0001407 ns/iter 1151627665.0000918 ns/iter 1.19
Micro_2019_09_KrakenD_Linter_Apply 12103532732.999838 ns/iter 10201953542.000069 ns/iter 1.19
Micro_2020_12_Dynamic_Ref 307.3553338075476 ns/iter 226.3610852162703 ns/iter 1.36
Micro_2020_12_Dynamic_Ref_Single 5.140920636587291 ns/iter 5.9146970308617135 ns/iter 0.87
Micro_2020_12_Simple_Output_Mask 122946.65533474855 ns/iter 141136.46782227486 ns/iter 0.87
Micro_2020_12_Simple_Output_Annotations 165539.9502347266 ns/iter 166381.40205448575 ns/iter 0.99
Micro_2020_12_Compile_NonCircular_Shared_Refs 931962.4553926226 ns/iter 1032580.5910448158 ns/iter 0.90

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (macos/llvm)

Details
Benchmark suite Current: b8a364a Previous: a5ceb92 Ratio
E2E_Compiler_adaptivecard 102126833.37499584 ns/iter 83199906.25000173 ns/iter 1.23
E2E_Compiler_ansible_meta 31777441.700000964 ns/iter 35270635.40000199 ns/iter 0.90
E2E_Compiler_aws_cdk 367611.5269461084 ns/iter 377897.75125973066 ns/iter 0.97
E2E_Compiler_babelrc 3295474.8975401744 ns/iter 2806974.3333327495 ns/iter 1.17
E2E_Compiler_clang_format 19493186.421055052 ns/iter 19407604.71795026 ns/iter 1.00
E2E_Compiler_cmake_presets 42768546.33332682 ns/iter 35962781.24999799 ns/iter 1.19
E2E_Compiler_code_climate 2932361.580524366 ns/iter 2608664.5622895462 ns/iter 1.12
E2E_Compiler_cql2 15720308.340000885 ns/iter 15575141.14285498 ns/iter 1.01
E2E_Compiler_cspell 31611759.999996137 ns/iter 26796200.892858583 ns/iter 1.18
E2E_Compiler_cypress 5028990.409998641 ns/iter 4648896.386667427 ns/iter 1.08
E2E_Compiler_deno 9013073.756754287 ns/iter 8678726.388888612 ns/iter 1.04
E2E_Compiler_dependabot 4927436.029411451 ns/iter 4513413.043478859 ns/iter 1.09
E2E_Compiler_draft_04 2708961.8873721953 ns/iter 2688722.4903475726 ns/iter 1.01
E2E_Compiler_fabric_mod 4659078.125000416 ns/iter 5202961.386667085 ns/iter 0.90
E2E_Compiler_geojson 32544297.619042914 ns/iter 30587463.739127837 ns/iter 1.06
E2E_Compiler_gitpod_configuration 4950978.408758096 ns/iter 5963362.919999327 ns/iter 0.83
E2E_Compiler_helm_chart_lock 685243.3980676556 ns/iter 681134.0746420728 ns/iter 1.01
E2E_Compiler_importmap 238623.13756068572 ns/iter 293026.32009725977 ns/iter 0.81
E2E_Compiler_jasmine 1266802.6814448873 ns/iter 1448779.4075547452 ns/iter 0.87
E2E_Compiler_jshintrc 3430943.720379339 ns/iter 4419539.262819865 ns/iter 0.78
E2E_Compiler_jsconfig 21737037.027776293 ns/iter 24114413.46153144 ns/iter 0.90
E2E_Compiler_krakend 186356614.49997088 ns/iter 176961722.33331707 ns/iter 1.05
E2E_Compiler_lazygit 43575085.93750481 ns/iter 40710282.3888863 ns/iter 1.07
E2E_Compiler_lerna 1873963.6803877354 ns/iter 1962198.5157065997 ns/iter 0.96
E2E_Compiler_nest_cli 8084440.0219780505 ns/iter 9728949.999998802 ns/iter 0.83
E2E_Compiler_omc 230312083.33327413 ns/iter 284367055.66665906 ns/iter 0.81
E2E_Compiler_omnisharp 9287796.41228111 ns/iter 8454825.087912947 ns/iter 1.10
E2E_Compiler_openapi 37587226.19047495 ns/iter 32397554.954544913 ns/iter 1.16
E2E_Compiler_pre_commit_hooks 5884292.8571417965 ns/iter 5505549.335999603 ns/iter 1.07
E2E_Compiler_pulumi 4491141.0066226795 ns/iter 4698475.190839452 ns/iter 0.96
E2E_Compiler_semantic_release 1656862.391143722 ns/iter 1834123.90692149 ns/iter 0.90
E2E_Compiler_stale 1695957.4771693056 ns/iter 1610691.1569148994 ns/iter 1.05
E2E_Compiler_stylecop 7256996.8584901905 ns/iter 7316914.092783562 ns/iter 0.99
E2E_Compiler_tmuxinator 1943135.7554346416 ns/iter 2034876.5869563885 ns/iter 0.95
E2E_Compiler_ui5 80014800.9999854 ns/iter 78281979.20000549 ns/iter 1.02
E2E_Compiler_ui5_manifest 449389124.99992514 ns/iter 526593832.9999926 ns/iter 0.85
E2E_Compiler_unreal_engine_uproject 4770810.121429544 ns/iter 4811547.076335865 ns/iter 0.99
E2E_Compiler_vercel 16991101.95744787 ns/iter 17281138.558140557 ns/iter 0.98
E2E_Compiler_yamllint 312091.3296883812 ns/iter 332355.0904977565 ns/iter 0.94
E2E_Evaluator_adaptivecard 28252.310863712806 ns/iter 29790.24641429662 ns/iter 0.95
E2E_Evaluator_ansible_meta 202179.020290713 ns/iter 206530.6244421638 ns/iter 0.98
E2E_Evaluator_aws_cdk 52181.93352435293 ns/iter 48855.47913561285 ns/iter 1.07
E2E_Evaluator_babelrc 110761.38364274047 ns/iter 123240.82654990545 ns/iter 0.90
E2E_Evaluator_cerebrum_criminal_case 1255666.7452471915 ns/iter 1396937.4210525933 ns/iter 0.90
E2E_Evaluator_clang_format 145780.97014028154 ns/iter 149045.22614705338 ns/iter 0.98
E2E_Evaluator_cmake_presets 4847624.423610519 ns/iter 5374538.620437479 ns/iter 0.90
E2E_Evaluator_code_climate 152593.72013862844 ns/iter 220361.2464183039 ns/iter 0.69
E2E_Evaluator_cql2 159568.131747092 ns/iter 188097.55036929622 ns/iter 0.85
E2E_Evaluator_cspell 414854.71948446264 ns/iter 575493.4999999932 ns/iter 0.72
E2E_Evaluator_cypress 152044.45494701114 ns/iter 186184.01506495054 ns/iter 0.82
E2E_Evaluator_deno 316417.27075028303 ns/iter 386661.0027855085 ns/iter 0.82
E2E_Evaluator_dependabot 370096.5969555711 ns/iter 436018.725268511 ns/iter 0.85
E2E_Evaluator_draft_04 5011859.374999025 ns/iter 7531741.349058428 ns/iter 0.67
E2E_Evaluator_fabric_mod 577164.4654234328 ns/iter 755370.3470824677 ns/iter 0.76
E2E_Evaluator_geojson 9975071.088236371 ns/iter 16067558.547617756 ns/iter 0.62
E2E_Evaluator_gitpod_configuration 162969.86129587155 ns/iter 252595.44691889547 ns/iter 0.65
E2E_Evaluator_helm_chart_lock 215976.3459059197 ns/iter 217756.3379945362 ns/iter 0.99
E2E_Evaluator_importmap 31792.956638441858 ns/iter 36214.81959951227 ns/iter 0.88
E2E_Evaluator_jasmine 81260.40353089146 ns/iter 82310.22326785474 ns/iter 0.99
E2E_Evaluator_jshintrc 925143.647552298 ns/iter 927930.1333333643 ns/iter 1.00
E2E_Evaluator_jsconfig 297039.62124418 ns/iter 305247.66811280657 ns/iter 0.97
E2E_Evaluator_krakend 128109.1017009531 ns/iter 145705.93626621985 ns/iter 0.88
E2E_Evaluator_lazygit 93486.2462050483 ns/iter 123567.93689320414 ns/iter 0.76
E2E_Evaluator_lerna 121545.60338805986 ns/iter 126926.56133895791 ns/iter 0.96
E2E_Evaluator_nest_cli 126717.04464767003 ns/iter 125666.58525755696 ns/iter 1.01
E2E_Evaluator_omc 14050.561119658996 ns/iter 15306.00403919555 ns/iter 0.92
E2E_Evaluator_omnisharp 412463.2728872976 ns/iter 438831.20190985035 ns/iter 0.94
E2E_Evaluator_openapi 7850878.318180322 ns/iter 7868612.873418114 ns/iter 1.00
E2E_Evaluator_pre_commit_hooks 328632.7433980031 ns/iter 353975.0721594606 ns/iter 0.93
E2E_Evaluator_pulumi 494554.30243904085 ns/iter 507934.6476923792 ns/iter 0.97
E2E_Evaluator_semantic_release 70913.36106320108 ns/iter 73041.04938011053 ns/iter 0.97
E2E_Evaluator_stale 110237.96980657104 ns/iter 125137.50074839543 ns/iter 0.88
E2E_Evaluator_stylecop 180974.28924496906 ns/iter 189056.53581811706 ns/iter 0.96
E2E_Evaluator_tmuxinator 68886.04397347782 ns/iter 69011.03387259848 ns/iter 1.00
E2E_Evaluator_ui5 345985.5531412393 ns/iter 411210.26144760614 ns/iter 0.84
E2E_Evaluator_ui5_manifest 1522718.0444913618 ns/iter 1978578.7132533812 ns/iter 0.77
E2E_Evaluator_unreal_engine_uproject 314974.7106947503 ns/iter 337174.65547444875 ns/iter 0.93
E2E_Evaluator_vercel 214309.56146181384 ns/iter 221306.31510419716 ns/iter 0.97
E2E_Evaluator_yamllint 8441.369157560803 ns/iter 9152.397570624182 ns/iter 0.92
Micro_Draft4_Meta_1_No_Callback 127.69451958061295 ns/iter 142.46215639607843 ns/iter 0.90
Micro_Draft4_Required_Properties 657.8536080057003 ns/iter 663.1918232940966 ns/iter 0.99
Micro_Draft4_Many_Optional_Properties_Minimal_Match 19.92554167958661 ns/iter 20.11365154388266 ns/iter 0.99
Micro_Draft4_Few_Optional_Properties_Minimal_Match 8.925970400951396 ns/iter 9.297782966557222 ns/iter 0.96
Micro_Draft4_Items_Schema 276.6806450074883 ns/iter 260.25663351033734 ns/iter 1.06
Micro_Draft4_Nested_Object 2.7075194043021895 ns/iter 3.04764063202012 ns/iter 0.89
Micro_Draft4_Properties_Triad_Optional 212.41322966683882 ns/iter 204.65167044257632 ns/iter 1.04
Micro_Draft4_Properties_Triad_Closed 166.40680126910064 ns/iter 190.28793758489726 ns/iter 0.87
Micro_Draft4_Properties_Triad_Required 212.07526442983357 ns/iter 229.0146000382583 ns/iter 0.93
Micro_Draft4_Properties_Closed 45.710829083287145 ns/iter 42.2070235389326 ns/iter 1.08
Micro_Draft4_Non_Recursive_Ref 12.684466108693032 ns/iter 12.980358459010956 ns/iter 0.98
Micro_Draft4_Pattern_Properties_True 154.72995787042794 ns/iter 153.41943592510876 ns/iter 1.01
Micro_Draft4_Ref_To_Single_Property 10.772587642865565 ns/iter 9.676089568358313 ns/iter 1.11
Micro_Draft4_Additional_Properties_Type 27.404145233993088 ns/iter 28.1767406125641 ns/iter 0.97
Micro_Draft4_Nested_Oneof 43.08348065222743 ns/iter 47.32782855424869 ns/iter 0.91
Micro_Draft4_Short_Enum 6.727549008967379 ns/iter 6.8029191410376315 ns/iter 0.99
Micro_Draft4_Long_Enum 12.038389677856507 ns/iter 11.697085181653797 ns/iter 1.03
Micro_Draft4_Long_Enum_Short_Strings 8.20613786601996 ns/iter 8.184213638724858 ns/iter 1.00
Micro_Draft4_Type_Object 4.054561341213508 ns/iter 4.081828486986499 ns/iter 0.99
Micro_Draft4_Ref_Single_100 1663082.5516431115 ns/iter 1724375.8166260372 ns/iter 0.96
Micro_Draft4_Compile_Ref_Many_Nested 1397681.8451728814 ns/iter 1270508.8435249596 ns/iter 1.10
Micro_Draft4_Compile_Wrap 2034099.8349832143 ns/iter 2083673.7407407388 ns/iter 0.98
Micro_Draft6_Property_Names 98.47381993694766 ns/iter 97.54622417330009 ns/iter 1.01
Micro_Draft6_Compile_FHIR 9493683041.99993 ns/iter 10301349042.000084 ns/iter 0.92
Micro_Draft7_If_Then_Else 18.850298609845847 ns/iter 19.554935142100412 ns/iter 0.96
Micro_2019_09_Unevaluated_Properties 27.853480583704645 ns/iter 31.61559003227786 ns/iter 0.88
Micro_2019_09_Compile_Wrap 319442332.9999836 ns/iter 336155708.0000921 ns/iter 0.95
Micro_2019_09_KrakenD_Linter_Check 631704708.000143 ns/iter 752401875.0000323 ns/iter 0.84
Micro_2019_09_KrakenD_Linter_Apply 6091289749.999988 ns/iter 6824531415.9999 ns/iter 0.89
Micro_2020_12_Dynamic_Ref 189.9141981640377 ns/iter 195.106433816371 ns/iter 0.97
Micro_2020_12_Dynamic_Ref_Single 4.431637815549011 ns/iter 4.229255225478817 ns/iter 1.05
Micro_2020_12_Simple_Output_Mask 142271.87572978658 ns/iter 137537.01158452398 ns/iter 1.03
Micro_2020_12_Simple_Output_Annotations 165005.91608075995 ns/iter 151841.91210720778 ns/iter 1.09
Micro_2020_12_Compile_NonCircular_Shared_Refs 744680.1535037507 ns/iter 847384.6153845863 ns/iter 0.88

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (linux/gcc)

Details
Benchmark suite Current: b8a364a Previous: a5ceb92 Ratio
Micro_2020_12_Dynamic_Ref 261.76232789160923 ns/iter 260.6540210391789 ns/iter 1.00
Micro_2020_12_Dynamic_Ref_Single 6.5709362813909795 ns/iter 6.651907706540044 ns/iter 0.99
Micro_2020_12_Simple_Output_Mask 138420.5515055115 ns/iter 137645.715044228 ns/iter 1.01
Micro_2020_12_Simple_Output_Annotations 174888.66541353537 ns/iter 171882.52358489396 ns/iter 1.02
Micro_2020_12_Compile_NonCircular_Shared_Refs 1131939.6165046934 ns/iter 1138853.588235048 ns/iter 0.99
Micro_2019_09_Unevaluated_Properties 32.10888414143173 ns/iter 31.193705976712458 ns/iter 1.03
Micro_2019_09_Compile_Wrap 308027470.99994576 ns/iter 333973422.4999802 ns/iter 0.92
Micro_2019_09_KrakenD_Linter_Check 1287587365.0000358 ns/iter 1307378710.9999557 ns/iter 0.98
Micro_2019_09_KrakenD_Linter_Apply 11519639057.999939 ns/iter 11818358475.999958 ns/iter 0.97
Micro_Draft7_If_Then_Else 28.65001872737835 ns/iter 29.491232452562063 ns/iter 0.97
Micro_Draft6_Property_Names 144.28364544444904 ns/iter 153.26153880726807 ns/iter 0.94
Micro_Draft6_Compile_FHIR 14863187331.999825 ns/iter 17769009068.99982 ns/iter 0.84
Micro_Draft4_Meta_1_No_Callback 170.2086552840052 ns/iter 172.4149244789325 ns/iter 0.99
Micro_Draft4_Required_Properties 823.319797169591 ns/iter 812.7375453187525 ns/iter 1.01
Micro_Draft4_Many_Optional_Properties_Minimal_Match 23.005658989103654 ns/iter 23.241001041247753 ns/iter 0.99
Micro_Draft4_Few_Optional_Properties_Minimal_Match 14.999543623744783 ns/iter 14.762777334617946 ns/iter 1.02
Micro_Draft4_Items_Schema 363.9727433543854 ns/iter 356.23533134214637 ns/iter 1.02
Micro_Draft4_Nested_Object 4.043621500628594 ns/iter 4.0459479653396215 ns/iter 1.00
Micro_Draft4_Properties_Triad_Optional 427.598843348852 ns/iter 395.16137608632863 ns/iter 1.08
Micro_Draft4_Properties_Triad_Closed 347.4577772580793 ns/iter 317.6801610205562 ns/iter 1.09
Micro_Draft4_Properties_Triad_Required 436.09952930219856 ns/iter 425.2509653604499 ns/iter 1.03
Micro_Draft4_Properties_Closed 64.85474487046267 ns/iter 63.45372738587323 ns/iter 1.02
Micro_Draft4_Non_Recursive_Ref 11.587217548518225 ns/iter 11.672376362202838 ns/iter 0.99
Micro_Draft4_Pattern_Properties_True 222.0704148881817 ns/iter 222.57503277482292 ns/iter 1.00
Micro_Draft4_Ref_To_Single_Property 14.992498249566342 ns/iter 14.807559912982112 ns/iter 1.01
Micro_Draft4_Additional_Properties_Type 16.559572843538945 ns/iter 16.91032878559262 ns/iter 0.98
Micro_Draft4_Nested_Oneof 69.79961854628027 ns/iter 66.7182535123411 ns/iter 1.05
Micro_Draft4_Short_Enum 14.078334502639128 ns/iter 14.067538760737296 ns/iter 1.00
Micro_Draft4_Long_Enum 15.985654683284723 ns/iter 16.639885248231177 ns/iter 0.96
Micro_Draft4_Long_Enum_Short_Strings 14.014903150325287 ns/iter 14.066647303067757 ns/iter 1.00
Micro_Draft4_Type_Object 6.5788708558130695 ns/iter 6.662870158455364 ns/iter 0.99
Micro_Draft4_Ref_Single_100 2418377.0862064506 ns/iter 2463740.294326839 ns/iter 0.98
Micro_Draft4_Compile_Ref_Many_Nested 1769548.2035176281 ns/iter 1786004.959079053 ns/iter 0.99
Micro_Draft4_Compile_Wrap 2490073.5287356554 ns/iter 2508516.89285696 ns/iter 0.99
E2E_Compiler_adaptivecard 63094479.09091597 ns/iter 75046955.22223099 ns/iter 0.84
E2E_Compiler_ansible_meta 28487458.639992837 ns/iter 29346609.583332866 ns/iter 0.97
E2E_Compiler_aws_cdk 395493.239641609 ns/iter 393511.3258300124 ns/iter 1.01
E2E_Compiler_babelrc 2641384.615385081 ns/iter 2651904.750000299 ns/iter 1.00
E2E_Compiler_clang_format 18583123.105264872 ns/iter 18959528.918918982 ns/iter 0.98
E2E_Compiler_cmake_presets 27159138.76922444 ns/iter 28033172.079994984 ns/iter 0.97
E2E_Compiler_code_climate 2663371.2137405407 ns/iter 2666382.6374038514 ns/iter 1.00
E2E_Compiler_cql2 13928842.27451242 ns/iter 14508399.857142687 ns/iter 0.96
E2E_Compiler_cspell 23409818.633331273 ns/iter 24465922.34482993 ns/iter 0.96
E2E_Compiler_cypress 4081890.7803459507 ns/iter 4085446.368420815 ns/iter 1.00
E2E_Compiler_deno 7735158.255554274 ns/iter 7825374.555555855 ns/iter 0.99
E2E_Compiler_dependabot 3993845.096590318 ns/iter 3960084.045454499 ns/iter 1.01
E2E_Compiler_draft_04 2792247.1075693597 ns/iter 2816802.0927422834 ns/iter 0.99
E2E_Compiler_fabric_mod 4908214.475523249 ns/iter 4977314.815602207 ns/iter 0.99
E2E_Compiler_geojson 22778877.29031781 ns/iter 24498969.482763264 ns/iter 0.93
E2E_Compiler_gitpod_configuration 4998879.749999625 ns/iter 5088518.579709935 ns/iter 0.98
E2E_Compiler_helm_chart_lock 710309.9989867583 ns/iter 716633.2126789265 ns/iter 0.99
E2E_Compiler_importmap 293276.86859782744 ns/iter 299056.29032253736 ns/iter 0.98
E2E_Compiler_jasmine 1394503.0838323997 ns/iter 1418900.8640000795 ns/iter 0.98
E2E_Compiler_jshintrc 4499626.025641682 ns/iter 4509976.425807479 ns/iter 1.00
E2E_Compiler_jsconfig 22120063.1874936 ns/iter 22614704.645166643 ns/iter 0.98
E2E_Compiler_krakend 139042720.39999342 ns/iter 161778845.50000954 ns/iter 0.86
E2E_Compiler_lazygit 33690418.619049266 ns/iter 35533681.549998164 ns/iter 0.95
E2E_Compiler_lerna 1635763.2482435617 ns/iter 1664980.2351543964 ns/iter 0.98
E2E_Compiler_nest_cli 7571247.967743275 ns/iter 7647668.641304198 ns/iter 0.99
E2E_Compiler_omc 157532705.74998623 ns/iter 181035572.74997684 ns/iter 0.87
E2E_Compiler_omnisharp 6764823.08737823 ns/iter 6829758.932039537 ns/iter 0.99
E2E_Compiler_openapi 25896326.518519614 ns/iter 27056788.884613946 ns/iter 0.96
E2E_Compiler_pre_commit_hooks 5478942.859374669 ns/iter 5521555.149607235 ns/iter 0.99
E2E_Compiler_pulumi 4163029.1488098963 ns/iter 4200867.952095757 ns/iter 0.99
E2E_Compiler_semantic_release 1628024.5186043282 ns/iter 1629557.475409916 ns/iter 1.00
E2E_Compiler_stale 1584034.3280180278 ns/iter 1595797.3789957133 ns/iter 0.99
E2E_Compiler_stylecop 5847056.900825197 ns/iter 5860946.2249989975 ns/iter 1.00
E2E_Compiler_tmuxinator 2000446.8857138946 ns/iter 2017911.244956718 ns/iter 0.99
E2E_Compiler_ui5 48055038.800005905 ns/iter 52054315.92307483 ns/iter 0.92
E2E_Compiler_ui5_manifest 318529324.9999859 ns/iter 366854340.49991274 ns/iter 0.87
E2E_Compiler_unreal_engine_uproject 4660596.926666282 ns/iter 4722155.18918863 ns/iter 0.99
E2E_Compiler_vercel 12871741.981480563 ns/iter 13397149.249997782 ns/iter 0.96
E2E_Compiler_yamllint 359560.62865949795 ns/iter 365346.61995854706 ns/iter 0.98
E2E_Evaluator_adaptivecard 24238.868620414425 ns/iter 24854.005629118856 ns/iter 0.98
E2E_Evaluator_ansible_meta 255834.29274521983 ns/iter 260450.23427090413 ns/iter 0.98
E2E_Evaluator_aws_cdk 51314.34466657643 ns/iter 51541.56278042486 ns/iter 1.00
E2E_Evaluator_babelrc 105743.29062780949 ns/iter 108132.32488867175 ns/iter 0.98
E2E_Evaluator_cerebrum_criminal_case 1341217.7169462172 ns/iter 1390203.1115535519 ns/iter 0.96
E2E_Evaluator_clang_format 106245.49431388867 ns/iter 108821.57503948043 ns/iter 0.98
E2E_Evaluator_cmake_presets 4506888.272151662 ns/iter 5717041.749999144 ns/iter 0.79
E2E_Evaluator_code_climate 191250.9438748494 ns/iter 194215.75616668642 ns/iter 0.98
E2E_Evaluator_cql2 223798.39120738584 ns/iter 226742.14896369746 ns/iter 0.99
E2E_Evaluator_cspell 545690.5625497128 ns/iter 563286.7827529582 ns/iter 0.97
E2E_Evaluator_cypress 175188.99924450705 ns/iter 175928.86206027365 ns/iter 1.00
E2E_Evaluator_deno 327418.49148642 ns/iter 327258.2957416865 ns/iter 1.00
E2E_Evaluator_dependabot 460587.07968130097 ns/iter 467519.6502002824 ns/iter 0.99
E2E_Evaluator_draft_04 6658125.336634208 ns/iter 9553447.652775858 ns/iter 0.70
E2E_Evaluator_fabric_mod 754184.7961374124 ns/iter 776026.1879865436 ns/iter 0.97
E2E_Evaluator_geojson 16433931.186045727 ns/iter 18646260.73683882 ns/iter 0.88
E2E_Evaluator_gitpod_configuration 254369.22983864107 ns/iter 258291.08477059597 ns/iter 0.98
E2E_Evaluator_helm_chart_lock 333418.2587278941 ns/iter 340964.4360351516 ns/iter 0.98
E2E_Evaluator_importmap 50124.741100012216 ns/iter 51802.547452106766 ns/iter 0.97
E2E_Evaluator_jasmine 118812.05589327555 ns/iter 119457.3728842214 ns/iter 0.99
E2E_Evaluator_jshintrc 1082629.7470414147 ns/iter 1052151.2927926825 ns/iter 1.03
E2E_Evaluator_jsconfig 404409.1002291011 ns/iter 411366.0928865361 ns/iter 0.98
E2E_Evaluator_krakend 204581.67479437575 ns/iter 209174.10374200795 ns/iter 0.98
E2E_Evaluator_lazygit 139792.9293077927 ns/iter 149127.33726163433 ns/iter 0.94
E2E_Evaluator_lerna 142796.39079754785 ns/iter 149879.48567815527 ns/iter 0.95
E2E_Evaluator_nest_cli 190731.68903440319 ns/iter 198234.1921668451 ns/iter 0.96
E2E_Evaluator_omc 19605.014294467765 ns/iter 20146.173566966572 ns/iter 0.97
E2E_Evaluator_omnisharp 569829.6233766592 ns/iter 579894.424013421 ns/iter 0.98
E2E_Evaluator_openapi 12441758.040815368 ns/iter 15892759.47727422 ns/iter 0.78
E2E_Evaluator_pre_commit_hooks 513856.5371050004 ns/iter 515784.044935285 ns/iter 1.00
E2E_Evaluator_pulumi 705972.7937308768 ns/iter 723889.9688148265 ns/iter 0.98
E2E_Evaluator_semantic_release 101449.94482958404 ns/iter 102458.77531270015 ns/iter 0.99
E2E_Evaluator_stale 157754.9556397597 ns/iter 159421.94766651886 ns/iter 0.99
E2E_Evaluator_stylecop 311518.6910786354 ns/iter 302495.04433712317 ns/iter 1.03
E2E_Evaluator_tmuxinator 98339.7972280083 ns/iter 97616.21003221233 ns/iter 1.01
E2E_Evaluator_ui5 544910.1505122265 ns/iter 561858.264181371 ns/iter 0.97
E2E_Evaluator_ui5_manifest 2750616.252918252 ns/iter 2988265.36744178 ns/iter 0.92
E2E_Evaluator_unreal_engine_uproject 466180.90517248114 ns/iter 466352.83355527726 ns/iter 1.00
E2E_Evaluator_vercel 313642.2936753289 ns/iter 319395.3005489793 ns/iter 0.98
E2E_Evaluator_yamllint 11786.614636616561 ns/iter 12022.451872373545 ns/iter 0.98

This comment was automatically generated by workflow using github-action-benchmark.

@jviotti jviotti marked this pull request as ready for review March 11, 2026 18:38
@jviotti jviotti changed the title [WIP] Keep Instruction additional data out of band in the Template Keep Instruction additional data out of band in the Template Mar 11, 2026
@augmentcode
Copy link

augmentcode bot commented Mar 11, 2026

🤖 Augment PR Summary

Summary: Refactors instruction metadata so it’s stored out-of-band from Instruction and carried via an index.

Changes:

  • Introduces `InstructionExtra` (schema pointer, keyword URI, schema resource id) and adds `Template::extra` to store it.
  • Replaces in-band `Instruction` fields (`relative_schema_location`, `keyword_location`, `schema_resource`) with `extra_index`.
  • Updates compiler helpers (`make*`, `unroll`, `rephrase`) and compiler passes to populate/consume metadata via a shared accumulator (`Context::extra`).
  • Updates postprocessing (`rebase`, jump expansion) to duplicate and rebase metadata in `extra` alongside instruction rewrites.
  • Updates JSON template serialization/deserialization to emit/restore instruction metadata via `extra_index` and `Template::extra`.
  • Extends evaluator callback/output plumbing to provide `InstructionExtra` to outputs (Simple/Trace) and adapts tests accordingly.

Technical Notes: This keeps fast-validation instructions smaller while still allowing tracking/callbacks and dynamic resource handling to access metadata through Template::extra.

🤖 Was this summary useful? React with 👍 or 👎

Copy link

@augmentcode augmentcode bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. 1 suggestion posted.

Fix All in Augment

Comment augment review to trigger a new review at any time.

Copy link

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3 issues found across 19 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="src/evaluator/include/sourcemeta/blaze/evaluator.h">

<violation number="1" location="src/evaluator/include/sourcemeta/blaze/evaluator.h:65">
P3: Update the callback documentation and example to include the new InstructionExtra parameter so the header comments match the API signature.</violation>
</file>

<file name="src/compiler/compile_helpers.h">

<violation number="1" location="src/compiler/compile_helpers.h:134">
P2: Copy the InstructionExtra by value before push_back; holding a reference to a vector element while pushing to the same vector can become invalid if the vector reallocates.</violation>
</file>

<file name="src/compiler/postprocess.h">

<violation number="1" location="src/compiler/postprocess.h:93">
P1: `extra.push_back(extra[instruction.extra_index])` passes a reference to an element of the same vector being appended to. If `push_back` reallocates, the source reference is invalidated mid-copy, which is undefined behavior. Copy to a local first:
```cpp
auto copy{extra[instruction.extra_index]};
extra.push_back(std::move(copy));
```</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

@jviotti jviotti force-pushed the metadata-array branch 2 times, most recently from c55aee7 to 575c326 Compare March 11, 2026 19:03
Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
@jviotti jviotti merged commit 53e432c into main Mar 13, 2026
13 checks passed
@jviotti jviotti deleted the metadata-array branch March 13, 2026 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant