Skip to content

Comments

fix: install in a different location for github actions#250

Merged
jviotti merged 1 commit intosourcemeta:mainfrom
v1v:feature/use-path-for-github-runners
Mar 6, 2025
Merged

fix: install in a different location for github actions#250
jviotti merged 1 commit intosourcemeta:mainfrom
v1v:feature/use-path-for-github-runners

Conversation

@v1v
Copy link
Contributor

@v1v v1v commented Mar 6, 2025

Something has changed in the /usr/local/bin permission

However, GitHub actions can modify on the fly the PATH using the GITHUB_PATH env variable as explained in https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/workflow-commands-for-github-actions#adding-a-system-path

Part of #249

Copy link
Member

@jviotti jviotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much!

@jviotti jviotti merged commit dc3bd46 into sourcemeta:main Mar 6, 2025
6 of 7 checks passed
@kleinschmidt
Copy link
Contributor

This doesn't seem to actually work in our workflows. It's installing to ~/.local/bin/bin but adding ~/.local/bin to the path; fix in #251

jviotti pushed a commit that referenced this pull request Mar 6, 2025
This is a followup to #250. The install script seems to want the install
root
and adds `/bin` to the install dir. This means that the action installs
the
binary to `${HOME}/.local/bin/bin` but adds `${HOME}/.local/bin` to the
path,
which at least in my workflow is not enough to pick up the installed
binary!
@jviotti
Copy link
Member

jviotti commented Mar 6, 2025

Ah, good catch. Makes sense now that I see the scripts again. Please try v7.0.2. I just published it with the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants