Skip to content

Disable orphan_definitions for now #594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jviotti merged 1 commit into from
Dec 26, 2025
Merged

Disable orphan_definitions for now #594

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/command_lint.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,10 @@ auto sourcemeta::jsonschema::lint(const sourcemeta::core::Options &options)
bundle.add<sourcemeta::blaze::ValidDefault>(
sourcemeta::blaze::default_schema_compiler);

// TODO: This rule has known problems we are working hard to fix right now
// See https://github.com/sourcemeta/core/pull/2145
bundle.remove("orphan_definitions");

if (options.contains("only")) {
if (options.contains("exclude")) {
throw OptionConflictError{
Expand Down
5 changes: 1 addition & 4 deletions test/lint/pass_lint_list_exclude.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,9 +139,6 @@ non_applicable_type_specific_keywords
not_false
Setting the `not` keyword to `false` imposes no constraints. Negating `false` yields the always-true schema

orphan_definitions
Schema definitions in `$defs` or `definitions` that are never internally referenced can be removed

pattern_properties_default
Setting the `patternProperties` keyword to the empty object does not add any further constraint

Expand Down Expand Up @@ -214,7 +211,7 @@ unsatisfiable_max_contains
unsatisfiable_min_properties
Setting `minProperties` to a number less than `required` does not add any further constraint

Number of rules: 68
Number of rules: 67
EOF

diff "$TMP/output.txt" "$TMP/expected.txt"
5 changes: 1 addition & 4 deletions test/lint/pass_lint_list_long.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,9 +145,6 @@ non_applicable_type_specific_keywords
not_false
Setting the `not` keyword to `false` imposes no constraints. Negating `false` yields the always-true schema

orphan_definitions
Schema definitions in `$defs` or `definitions` that are never internally referenced can be removed

pattern_properties_default
Setting the `patternProperties` keyword to the empty object does not add any further constraint

Expand Down Expand Up @@ -220,7 +217,7 @@ unsatisfiable_max_contains
unsatisfiable_min_properties
Setting `minProperties` to a number less than `required` does not add any further constraint

Number of rules: 70
Number of rules: 69
EOF

diff "$TMP/output.txt" "$TMP/expected.txt"
5 changes: 1 addition & 4 deletions test/lint/pass_lint_list_short.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,9 +145,6 @@ non_applicable_type_specific_keywords
not_false
Setting the `not` keyword to `false` imposes no constraints. Negating `false` yields the always-true schema

orphan_definitions
Schema definitions in `$defs` or `definitions` that are never internally referenced can be removed

pattern_properties_default
Setting the `patternProperties` keyword to the empty object does not add any further constraint

Expand Down Expand Up @@ -220,7 +217,7 @@ unsatisfiable_max_contains
unsatisfiable_min_properties
Setting `minProperties` to a number less than `required` does not add any further constraint

Number of rules: 70
Number of rules: 69
EOF

diff "$TMP/output.txt" "$TMP/expected.txt"
Loading