feat: Handle missing ECS deployment gracefully when replaced#20
Merged
iBotPeaches merged 2 commits intomasterfrom Jul 9, 2025
Merged
feat: Handle missing ECS deployment gracefully when replaced#20iBotPeaches merged 2 commits intomasterfrom
iBotPeaches merged 2 commits intomasterfrom
Conversation
iBotPeaches
reviewed
Jun 11, 2025
Contributor
Author
|
When an external or manual redeploy occurs in ECS, the original deployment can be removed from the service’s deployments array almost immediately. In this case, the deployment ID the script is polling for is no longer present in the response from Would you like for me to add a debug print? |
Member
I think if we mess with an internal project (template possibly). Lets re-deploy Alpha, then force a deployment in AWS to replicate the error. Once we see we are replicating the error in the polling, we can make the API call manually in CURL to get body. Can you setup the tools to run that test to get a good real sample? |
Contributor
Author
|
I can give it a shot. |
iBotPeaches
approved these changes
Jul 9, 2025
jweberst
approved these changes
Jul 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves the robustness of the ECS deployment polling script. Previously, if a deployment was replaced by a manual or external redeploy while the GitHub Action was polling, the script would fail or exit with unclear messaging. Now, if the deployment ID is no longer found (indicating a replacement), the script exits gracefully with a clear message.