fix: check for any non-zero container error#23
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes container error checking by examining all containers in a task instead of just the first one. The change ensures that any non-zero exit code from any container will cause the deployment to fail.
- Replaces single-container exit code check with a check across all containers
- Maintains the same success/failure messaging and behavior
- Uses jq to filter containers with non-zero exit codes
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
|
Yeah the problem is now that we can get many numerics back (if more than 1 container fails). This will take some more thinking |
|
Maybe the solution is to just change to this: echo -e "${RED}Task returned non-zero exit code. Raw response is below:"; Since there are now multiple containers with multiple exit codes, it would be better to just print the raw response and people can look at output. |
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
fixes: #22