build: correct jq checks to be valid against task def files#28
Merged
iBotPeaches merged 1 commit intomasterfrom Jan 29, 2026
Merged
build: correct jq checks to be valid against task def files#28iBotPeaches merged 1 commit intomasterfrom
iBotPeaches merged 1 commit intomasterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes inverted logic in JSON validation checks that were causing the script to fail when JSON was valid and pass when JSON was invalid. The fix uses jq -e with proper exit code checking instead of relying on jq's default behavior.
Changes:
- Fixed JSON validation logic for task definition files to properly detect invalid JSON
- Fixed JSON validation logic for network configuration files to properly detect invalid JSON
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Bankamah
approved these changes
Jan 28, 2026
jweberst
approved these changes
Jan 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The older logic was wrong - always passing (during a failure) and failing during a pass. It seems earlier versions of JQ had a different default mode when invoked without parameters which generated invalid json (escaped chars) which failed the check.
In modern jq the default execution no longer does that, so it works (but then fails since our logic was inverted).
I moved this to properly look at exit code
-e.Testing
Fixes #25