Skip to content

support MySQL 8.4 for mysql-tools repo#72

Merged
ramereth merged 2 commits intosous-chefs:mainfrom
gwhelan:issue-71
Dec 16, 2025
Merged

support MySQL 8.4 for mysql-tools repo#72
ramereth merged 2 commits intosous-chefs:mainfrom
gwhelan:issue-71

Conversation

@gwhelan
Copy link
Contributor

@gwhelan gwhelan commented Dec 16, 2025

Description

  • set the repo url based on MySQL version

Issues Resolved

  • incorrect version of tools repo installed for 8.4

Check List

  • All commit messages follow Conventional Commits format
    • Required: This triggers our automated CHANGELOG and release pipeline (release-please)
    • Without conventional commits, your changes cannot be released
    • Examples: fix: resolve bug in resource, feat: add new property, docs: update README
  • New functionality includes testing
  • New functionality has been documented in the README if applicable

⚠️ Important: Automated Release Workflow

DO NOT manually edit these files:

  • metadata.rb version - Managed by release-please
  • CHANGELOG.md - Auto-generated from conventional commits
  • ❌ Version tags - Created automatically on release

The release process:

  1. Merge PR with conventional commits → release-please creates a release PR
  2. Merge release PR → automatic version bump, CHANGELOG update, and Supermarket publish
  3. Your changes are released! 🎉

Need help? See Conventional Commits guide

@gwhelan gwhelan requested a review from a team as a code owner December 16, 2025 17:05
@gwhelan gwhelan force-pushed the issue-71 branch 2 times, most recently from 658f7e0 to c8ae04c Compare December 16, 2025 17:08
@ramereth
Copy link
Contributor

@gwhelan can you please fix the linting issue?

@gwhelan
Copy link
Contributor Author

gwhelan commented Dec 16, 2025

@ramereth fixed.

@ramereth ramereth merged commit 467d1d5 into sous-chefs:main Dec 16, 2025
16 of 27 checks passed
@gwhelan
Copy link
Contributor Author

gwhelan commented Dec 16, 2025

@ramereth do I need to do anything to get this released? The docs say a release PR should be generated on merge, but I do not see such a PR, wondering if thats internal to maintainers or not.

@ramereth
Copy link
Contributor

@gwhelan I'm asking other sous-chef admins to see why it didn't trigger a release PR

@gwhelan
Copy link
Contributor Author

gwhelan commented Dec 18, 2025

@ramereth any update?

@ramereth
Copy link
Contributor

@gwhelan looks like the release config was wrong. I just fixed it and did release. Sorry it took so long!

@gwhelan
Copy link
Contributor Author

gwhelan commented Dec 18, 2025

no problem! I saw! thank you do much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants