Update prism requirement from >= 0.29, < 1.3 to >= 0.29, < 1.5#199
Closed
dependabot[bot] wants to merge 1 commit intomainfrom
Closed
Update prism requirement from >= 0.29, < 1.3 to >= 0.29, < 1.5#199dependabot[bot] wants to merge 1 commit intomainfrom
dependabot[bot] wants to merge 1 commit intomainfrom
Conversation
Updates the requirements on [prism](https://github.com/ruby/prism) to permit the latest version. - [Release notes](https://github.com/ruby/prism/releases) - [Changelog](https://github.com/ruby/prism/blob/main/CHANGELOG.md) - [Commits](ruby/prism@v1.2.0...v1.4.0) --- updated-dependencies: - dependency-name: prism dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
ac44673 to
e8affc9
Compare
koic
reviewed
Apr 10, 2025
| spec.require_paths = ["lib"] | ||
|
|
||
| spec.add_dependency "prism", ">= 0.29", "< 1.3" | ||
| spec.add_dependency "prism", ">= 0.29", "< 1.5" |
There was a problem hiding this comment.
It doesn't seem necessary to lock the upper (minor) version bound of Prism. I've heard from user feedback that they were unable to resolve versions when using the latest RuboCop (RuboCop AST), which requires Prism 1.4+. As a reference, RuboCop doesn't plan to lock an upper bound on minor Prism version:
https://github.com/rubocop/rubocop-ast/blob/v1.44.0/rubocop-ast.gemspec#L37
It's probably better to leave the Prism version up to users, I think.
Contributor
Author
|
Superseded by #210. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the requirements on prism to permit the latest version.
Release notes
Sourced from prism's releases.
Changelog
Sourced from prism's changelog.
Commits
1463122Merge pull request #3500 from ruby/bump-version71d31dbBump to v1.4.0e8f784eMerge pull request #3499 from ruby/concat-xstringsf734350Make xstrings concat syntax errorcec425cMerge pull request #3498 from ruby/update-trufflruby2afe89fUpdate truffleruby version55408bfMerge pull request #3496 from ruby/multiple-statements-flagb63b5d6Add a multiple statements flag to parentheses5c04045Merge pull request #3495 from ruby/dont-require-set-until-needed422d5c4Use Set.new over to_setDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)