Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/steep/services/signature_service.rb
Original file line number Diff line number Diff line change
Expand Up @@ -295,7 +295,7 @@ def update_env(updated_files, paths:)

unless errors.empty?
# Builder won't be used.
factory = AST::Types::Factory.new(builder: _ = nil)
factory = AST::Types::Factory.new(builder: RBS::DefinitionBuilder.new(env: env, ancestor_builder: builder))
return errors.map {|error| Diagnostic::Signature.from_rbs_error(error, factory: factory) }
end

Expand Down
2 changes: 2 additions & 0 deletions smoke/diagnostics-rbs/invalid-type-application-class.rbs
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
class InvalidTypeApplicationClass < String[String]
end
2 changes: 2 additions & 0 deletions smoke/diagnostics-rbs/invalid-type-application-module.rbs
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
module InvalidTypeApplicationModule : String[int]
end
24 changes: 24 additions & 0 deletions smoke/diagnostics-rbs/test_expectations.yml
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,30 @@
severity: ERROR
message: Cannot find a non-overloading definition of `foo` in `::InvalidMethodOverload`
code: RBS::InvalidMethodOverload
- file: invalid-type-application-class.rbs
diagnostics:
- range:
start:
line: 1
character: 36
end:
line: 1
character: 50
severity: ERROR
message: Type `::String` is not generic but used as a generic type with 1 arguments
code: RBS::InvalidTypeApplication
- file: invalid-type-application-module.rbs
diagnostics:
- range:
start:
line: 1
character: 38
end:
line: 1
character: 49
severity: ERROR
message: Type `::String` is not generic but used as a generic type with 1 arguments
code: RBS::InvalidTypeApplication
- file: invalid-type-application.rbs
diagnostics:
- range:
Expand Down