Skip to content

Conversation

@mehershiri
Copy link
Contributor

@mehershiri mehershiri commented Aug 22, 2025

Related Issue

Fixed the theme icons. Now the light mode icon is displayed in dark mode and dark mode icon in light mode.

Fixes #217

Type of PR

  • Bug fix
  • Feature enhancement
  • Documentation update
  • Other (specify): _______________

Screenshots

Screenshot (328) Screenshot (329)

Checklist:

  • I have made this change from my own.
  • I have mentioned the issue number in my Pull Request.
  • I have gone through the CONTRIBUTING.md file before contributing
  • I have performed a self-review of my own code.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers and screenshots after making the changes.

@vercel
Copy link

vercel bot commented Aug 22, 2025

@mehershiri is attempting to deploy a commit to the Souvik's projects Team on Vercel.

A member of the Team first needs to authorize it.

@netlify
Copy link

netlify bot commented Aug 22, 2025

Deploy Preview for learnhub5 ready!

Name Link
🔨 Latest commit d440e7a
🔍 Latest deploy log https://app.netlify.com/projects/learnhub5/deploys/68a82c8f61be160008318ad7
😎 Deploy Preview https://deploy-preview-223--learnhub5.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions
Copy link

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible.). If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@mehershiri mehershiri changed the title Swizzled ColorModeToggle and NavbarContent to swap theme icons Fixed and swapped the theme icons Aug 22, 2025
@mehershiri
Copy link
Contributor Author

@souvikpramanikgit please review the PR

@souvikpramanikgit souvikpramanikgit merged commit 5530f06 into souvikpramanikgit:main Aug 22, 2025
5 of 6 checks passed
@github-actions
Copy link

🎉🎉 Thank you for your contribution! Your PR #223 has been merged! 🎉🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: The theme symbols must be the opposite

2 participants