Streamline Configuration Loading in Conversation Config Module#95
Open
Mefisto04 wants to merge 1 commit intosouzatharsis:mainfrom
Open
Streamline Configuration Loading in Conversation Config Module#95Mefisto04 wants to merge 1 commit intosouzatharsis:mainfrom
Mefisto04 wants to merge 1 commit intosouzatharsis:mainfrom
Conversation
Author
|
hey @souzatharsis please review this |
Owner
|
Will do, apologies I was out this week.
…On Thu, Oct 24, 2024 at 4:56 PM Mayur Kawale ***@***.***> wrote:
hey @souzatharsis <https://github.com/souzatharsis> please review this
—
Reply to this email directly, view it on GitHub
<#95 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADTMY3LJM72UHAQ4ACU55SDZ5FGHFAVCNFSM6AAAAABQK5GMFGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMZWGIZDQMRVHA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Owner
|
automated tests indicate api keys are not found. please check above logs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces several minor yet impactful changes to improve the robustness and clarity of the Conversation Configuration Module:
Improved Error Handling:
FileNotFoundErrorandyaml.YAMLErrorfor clearer error messages.Streamlined Configuration Loading:
get_conversation_config_pathmethod to reduce redundancy by using a loop to check for the configuration file in multiple locations.Simplified Deep Copy Logic:
__init__method by directly updatingself.config_conversationwith the loaded configuration, eliminating the need for deep copying.These changes enhance the overall maintainability and error reporting of the module, providing a clearer understanding of issues during configuration loading.
Code Snippet