fix: Fix custom managers being ignored leading to DoesNotExist exception #318
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
i was just about to develop a fix like this myself... thank you to everyone involved in creating this patch! |
jheld
reviewed
Aug 1, 2025
| ) | ||
| assert crud_event_qs.count() == 1 | ||
|
|
||
| obj.name = "this should not fail" |
Collaborator
There was a problem hiding this comment.
I'm currently having a bit of trouble understanding how this test is proving the fix. Can you add more information in the test or perhaps outline more of it in discussion?
Hmm, nevermind. Had to re-read this. Of course it's dependent on which queryset manager is applied. By using the base, we know we'll be safe.
|
This worked for me. Can this be merged soon? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an updated version of @JirkaV 's pr #176 fixing issue #175.