Closed
Conversation
Copilot
AI
changed the title
[WIP] Plan thorough security review for app
Security review plan for Kaset
Dec 20, 2025
sozercan
added a commit
that referenced
this pull request
Feb 22, 2026
- Fix #1: Test that only accepted tracks are removed from queue during flush - Fix #2: Test replay detection logic (backward progress jump threshold) - Fix #3: Test parseScrobbleResponse reads corrected name from #text, not flag - Fix #7: Test CancellationError stops flush processing and keeps tracks in queue - Fix #8: Test 30-second minimum duration guard for scrobbling - Fix flaky scrobbleTrackEquality test (timestamp race on CI) - Make parseScrobbleResponse internal for testability
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Created a comprehensive security assessment plan for the macOS YouTube Music client covering authentication, network security, cryptography, data storage, and WebView attack surface.
Scope
10-phase security review covering:
window.webkit.messageHandlers), script injection, CSPcom.apple.security.cs.jit), sandbox constraintsKey Areas of Interest
SAPISIDHASH Authentication
JavaScript Bridge
Singleton WebView Pattern
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.