Skip to content

fix: use video.paused for play/pause state detection #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sozercan merged 1 commit into from
Jan 26, 2026
Merged

fix: use video.paused for play/pause state detection #87

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions Views/macOS/MiniPlayerWebView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,17 +120,16 @@ struct MiniPlayerWebView: NSViewRepresentable {
const titleEl = document.querySelector('.ytmusic-player-bar.title');
const artistEl = document.querySelector('.ytmusic-player-bar.byline');
const progressBar = document.querySelector('#progress-bar');
const playPauseBtn = document.querySelector('.play-pause-button.ytmusic-player-bar');

const title = titleEl ? titleEl.textContent : '';
const artist = artistEl ? artistEl.textContent : '';
const progress = progressBar ? parseInt(progressBar.getAttribute('value') || '0') : 0;
const duration = progressBar ? parseInt(progressBar.getAttribute('aria-valuemax') || '0') : 0;

// Check if playing by looking at the button title
const isPlaying = playPauseBtn ?
playPauseBtn.getAttribute('title') === 'Pause' ||
playPauseBtn.getAttribute('aria-label') === 'Pause' : false;
// Use video element's paused property for language-agnostic detection
// Previously checked button title/aria-label which fails for non-English locales
const video = document.querySelector('video');
const isPlaying = video ? !video.paused : false;

bridge.postMessage({
type: 'STATE_UPDATE',
Expand Down
8 changes: 4 additions & 4 deletions Views/macOS/SingletonPlayerWebView+ObserverScript.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,10 +211,10 @@ extension SingletonPlayerWebView {
lastUpdateTime = now;

try {
const playPauseBtn = document.querySelector('.play-pause-button.ytmusic-player-bar');
const isPlaying = playPauseBtn ?
(playPauseBtn.getAttribute('title') === 'Pause' ||
playPauseBtn.getAttribute('aria-label') === 'Pause') : false;
// Use video element's paused property for language-agnostic detection
// Previously checked button title/aria-label which fails for non-English locales
const video = document.querySelector('video');
const isPlaying = video ? !video.paused : false;

const progressBar = document.querySelector('#progress-bar');

Expand Down
Loading