fix: prevent duplicate window on reopen from dock#92
Merged
Conversation
Use Window scene instead of WindowGroup to prevent SwiftUI from creating a second window when the app is reopened via dock icon while the original window is hidden (not closed). WindowGroup is designed for multi-window apps and creates a new window instance when no visible window exists. Window is a single- instance scene type that correctly handles the hidden window case.
sozercan
force-pushed
the
fix/duplicate-window-on-reopen
branch
from
3d5cd9e to
b4ce482
Compare
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where clicking the dock icon to reopen the app after closing the window would create duplicate windows. The fix changes the scene type from WindowGroup to Window with a unique ID.
Changes:
- Changed from
WindowGroupscene toWindow("Kaset", id: "main")scene to prevent duplicate window creation - The
Windowscene type is a single-instance scene that correctly handles the hidden window case
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Windowscene instead ofWindowGroupto prevent duplicate windows when reopening from dockProblem
When closing the window (hiding, not quitting) and clicking the dock icon to reopen, two windows appeared:
applicationShouldHandleReopenWindowGroup(which creates new instances when no visible window exists)Solution
Changed from
WindowGrouptoWindow("Kaset", id: "main")which is a single-instance scene type that correctly handles the hidden window case without creating duplicates.Test plan