Skip to content

feat: patch verify_ecdsa along with recovery #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: patch-secp256k1-v0.29.0
Choose a base branch
from
Open

feat: patch verify_ecdsa along with recovery #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ab2856f
now points to my branch of ecdsa-core which accelerates verify_prehash
umadayal Oct 11, 2024
ec5a715
recover_from_prehash
umadayal Oct 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ wasm-bindgen-test = "0.3"
getrandom = { version = "0.2", features = ["js"] }

[target.'cfg(all(target_os = "zkvm", target_vendor = "succinct"))'.dependencies]
sp1-ecdsa = { git = "https://github.com/sp1-patches/signatures", branch = "patch-ecdsa-v0.16.9", package = "ecdsa", features = ["verifying", "alloc"] }
sp1-ecdsa = { git = "https://github.com/sp1-patches/signatures", branch = "umadayal/secp256r1", package = "ecdsa", features = ["verifying", "alloc"] }
k256 = { version = "0.13.3", features = ["ecdsa"] }
elliptic-curve = { version = "0.13.6", default-features = false, features = ["digest", "sec1"] }

Expand Down
2 changes: 1 addition & 1 deletion src/ecdsa/recovery.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,7 @@ impl<C: Verification> Secp256k1<C> {
// The recovery ID is the last byte of the signature.
let recovery_id = sp1_ecdsa::RecoveryId::from_byte(sig.0[64]).unwrap();

let verifying_key = sp1_ecdsa::VerifyingKey::recover_from_prehash_secp256k1(prehash, &signature, recovery_id).unwrap();
let verifying_key = sp1_ecdsa::VerifyingKey::recover_from_prehash(prehash, &signature, recovery_id).unwrap();
let verifying_key_bytes = {
// Convert the verifying key to a byte array. The encoded point returned by `to_encoded_point` is in uncompressed format,
// with the prefix byte (0x04) and two 32-byte coordinates in big-endian format. This needs to be flipped to little-endian
Expand Down