Skip to content

Conversation

@mkhansenbot
Copy link
Contributor

@mkhansenbot mkhansenbot commented Aug 26, 2025

Moves the space_robots demo from the docker repo to this repo (demos). This is dependent on merging space-ros/docker#255 so that this container can pull the space-ros-moveit2 image

This fixes space-ros/docker#256

@mkhansenbot mkhansenbot changed the title Move space_robots from docker repo (docker issue #256) Move space_robots from docker repo (space-ros/docker#256) Sep 4, 2025
@mkhansenbot
Copy link
Contributor Author

Per the discussion in the technical WG today, I will update the commit message to be more clear that it fixes the space-ros/docker#256 issue, and add additional comments that the history prior to this point is in the docker repo.

@mkhansenbot mkhansenbot marked this pull request as ready for review October 1, 2025 22:44
@mkhansenbot
Copy link
Contributor Author

This is ready for review

The only caveat - it currently uses the "moveit2:main" image as a base. Once we release our next release (end of month) in the docker repo, a new image will be generated - "moveit2:latest" and this should be updated to use that image instead. I'll file an issue to track this, if this is approved.

@eholum
Copy link
Member

eholum commented Oct 2, 2025

Currently building and will sanity check!

In the interim... this is basically a straight copy paste right? In the past I've done something unholy when merging between repos and updating commit messages: space-ros/space-ros#167. I personally think that's overkill, but maybe it's worth updating the README.md to note that it was moved from a different repo? That would at least preserve the link between projects if there were some need to go back in time.

@eholum
Copy link
Member

eholum commented Oct 2, 2025

Side note, @EzraBrooks, can you update the repo settings to require approval before merging PRs? That merge button is just sitting there tempting me.

Copy link
Member

@eholum eholum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a quick sanity check and found the instructions to be a little off. I haven't been following demo evolution lately so maybe I'm missing something? In any case... would be good to at least tweak the readme so that these work out of the box.

On the plus side they do indeed work out of the box! So much faster to build and run these. Thanks for the work here, @mkhansenbot.

@EzraBrooks
Copy link
Member

I apparently don't have access to this repo's settings. cc @gbiggs

@mkhansenbot
Copy link
Contributor Author

Addressed @eholum review feedback, updating the README to use the new launch method of launching GUI and control separately

Copy link
Member

@eholum eholum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does the thing! Thanks for the README updates it just worked out of the box for me.

@EzraBrooks EzraBrooks merged commit 048ad8a into main Oct 10, 2025
3 checks passed
@EzraBrooks EzraBrooks added this to the jazzy-2025.10.0 milestone Oct 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move Space Robots to the demos repo

4 participants