Enable the PR CI job to be run manually (#215).#216
Enable the PR CI job to be run manually (#215).#216ivanperez-keera wants to merge 1 commit intomainfrom
Conversation
Bckempa
left a comment
There was a problem hiding this comment.
I was kind of surprised to see the colons with no child attributes and since we don't have any child conditions of these triggers at the moment another valid syntax is on: [pull_request, workflow_dispatch], but if this works I'm happy with it.
How confident are we that a manual run will get picked up but a stuck PR?
EzraBrooks
left a comment
There was a problem hiding this comment.
This still puts the burden of the re-run onto the maintainers, since the average contributor can't hit this button. I would advise that we just use the typical strategy of putting up an empty commit temporarily to re-trigger the web hooks when we see GitHub lose an Action run.
I disagree. It doesn't put the burden on the maintainers, it gives them a possibility that otherwise they would not have. If you add an empty commit, either you have to merge a PR with an empty commit, which is just noise, or when you remove it, the PR and the repo don't match (the PR doesn't really check a commit that was merged). |
I still disagree, but arguing would be a waste of time.
ea2c787 to
103e452
Compare
a6e4de0 to
26f976c
Compare
26f976c to
16c5ade
Compare
|
@ivanperez-keera - Can we merge this? |
16c5ade to
e547fdf
Compare
|
We've decided not to include this yet. We'll keep an eye to see if the problem really keeps happening and merge only in that case. Please do not scope this for any release yet. |
The PR workflow CI job sometimes gets stuck, and there's no way to manually trigger it so that it completes. This prevents PRs from being merged. This commit adjusts the conditions for the job to run so that it can be executed manually if needed.
e547fdf to
26e07b8
Compare
|
Can we close this? If we're not going to merge it, then I think we should. |
The PR workflow CI job sometimes gets stuck, and there's no way to manually trigger it so that it completes. This prevents PRs from being merged.
This commit adjusts the conditions for the job to run so that it can be executed manually if needed.