Fix Erronius entity deletion on grid deletion from SetTiles() #6367
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Princess-Cheeseballs
requested review from
DrSmugleaf and
PJB3005
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SetTiles has RegenerateCollisions() happen before TileChangedEvent is raised.
TileChangedEvent is used to unanchor and unparent entities on the grid.
RegenerateCollisions will delete the grid and everything parented to it, if there are no tiles left.
This means if all tiles on a grid are destroyed simultaneously, all entities on that grid get deleted with no chance to save themselves. This doesn't happen with the normal SetTile method, just this one.
I swapped the other these methods execute to fix the bug.