Turn ColorSelectorSliders into robust xaml + add hex color field to color sliders #6370
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
ready for review |
PJB3005
requested changes
Jan 7, 2026
Comment on lines
7
to
9
| /// A LineEdit control that displays in a monospace font. | ||
| /// Because the font is monospace, this allows you to resize the control based on the size | ||
| /// of a given "test string", using <see cref="MeasureText"/>. |
Member
There was a problem hiding this comment.
Uhm, that has nothing to do with it being monospace?
Also this API is too niche to be public.
Contributor
Author
|
tried my best to address the reviews |
PJB3005
requested changes
Jan 10, 2026
|
|
||
| [GenerateTypedNameReferences] | ||
| [Access(typeof(ColorSelectorSliders))] | ||
| public sealed partial class AlphaSliderChannel : BoxContainer, ISliderChannel |
|
|
||
| [GenerateTypedNameReferences] | ||
| [Access(typeof(ColorSelectorSliders))] | ||
| public sealed partial class ColorSliderChannel : BoxContainer, ISliderChannel |
Contributor
Author
There was a problem hiding this comment.
just to be clear:
- robust xaml can't generate controls that aren't public, right
- if yes, then in this case, we want these controls to be pure c#?
Member
There was a problem hiding this comment.
robust xaml can't generate controls that aren't public, right
Yes it can?
Contributor
Author
There was a problem hiding this comment.
oh huh, i feel like i was getting errors last time i tried. i could give it a shot later...? are there examples in the code where this is done?
Member
There was a problem hiding this comment.
are there examples in the code where this is done?
All over the place in engine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cleans up the initialization code of
ColorSelectorSliders.csby turning it into a Robust XAML control, which, from what I can gather, is something we are aiming to do eventually anyway.It also adds a new hex color field to the control, allowing players to (for once!) actually copy-paste colors to/from the color sliders, which is IMO pretty important for QOL
color.mp4