Add events on animation starts #6382
Merged
+33
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PJB3005
requested changes
Jan 19, 2026
Robust.Client/GameObjects/EntitySystems/AnimationPlayerSystem.cs
Outdated
Show resolved
Hide resolved
Robust.Client/GameObjects/EntitySystems/AnimationPlayerSystem.cs
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Thanks for reviewing, requested changes are in. |
PJB3005
approved these changes
Jan 19, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an
AnimationStartedEventfired by theAnimationPlayerSystem. It's set to broadcast in order to be consistent with the existingAnimationCompletedEvent.Also gives
ControlanAnimationStartedevent for consistency's sake as well.The reason for this is to give content systems more awareness about animations and let them react to them if desired. Also, it feels right to have this given
AnimationCompletedEventis already available. Finally, it would be useful for my proposed Animation State Machine.