Skip to content

Conversation

@notquitehadouken
Copy link
Contributor

@notquitehadouken notquitehadouken commented Jan 5, 2026

About the PR

Title
You can still smart equip magazines into your gun
Also applies to some other stuff like flashlights

Why / Balance

if it's called smart equip why is it so dumb
Typically when you want to grab out of your back slot, and your back slot has a gun, you want to grab your gun

Technical details

Adds IgnoreContentsOnSmartEquipComponent, which is the PR
ignoreContents in SmartEquipSystem is used to skip the checks for slots and storage, acting as if the item in your inventory hasn't either
Added - type: IgnoreContentsOnSmartEquip to eight prototypes which (hopefully, hopefully) covers every gun with a magazine

Media

converted.mp4

Requirements

Breaking changes

Changelog

🆑

  • fix: You no longer grab the magazines out of guns when attempting to smart equip them

@PJBot PJBot added S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. S: Needs Review Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved. size/S Denotes a PR that changes 10-99 lines. labels Jan 5, 2026
@kontakt kontakt added T: Bugfix Type: Bugs and/or bugfixes P2: Raised Priority: Item has a raised priority, indicating it might get increased maintainer attention. D2: Medium Difficulty: A good amount of codebase knowledge required. A: General Interactions Area: General in-game interactions that don't relate to another area. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Jan 5, 2026
@kontakt
Copy link
Contributor

kontakt commented Jan 5, 2026

This also needs to be applied to battery devices such as flashlights.

@notquitehadouken
Copy link
Contributor Author

i forgot pockets existed

@arenaconspiracy
Copy link

Duplicate of #41275
Do not write "in-character changelogs". Explain out-of-character mechanics cleanly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A: General Interactions Area: General in-game interactions that don't relate to another area. D2: Medium Difficulty: A good amount of codebase knowledge required. P2: Raised Priority: Item has a raised priority, indicating it might get increased maintainer attention. S: Needs Review Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved. size/S Denotes a PR that changes 10-99 lines. T: Bugfix Type: Bugs and/or bugfixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants