Skip to content

Fix adding reactions #1576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MathMan05 wants to merge 2 commits into from
Closed

Fix adding reactions #1576

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2b2ad1c
Fix adding reactions
MathMan05 Mar 7, 2026
408c594
give remove the same treatment
MathMan05 Mar 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 13 additions & 11 deletions src/api/routes/channels/#channel_id/messages/#message_id/reactions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ import {
MessageReactionRemoveEvent,
User,
arrayRemove,
ReactionType,
} from "@spacebar/util";
import { Request, Response, Router } from "express";
import { HTTPError } from "lambert-server";
Expand Down Expand Up @@ -224,14 +225,12 @@ router.put(

await message.save();

const member =
channel.guild_id &&
(
await Member.findOneOrFail({
where: { id: req.user_id },
select: PublicMemberProjection,
})
).toPublicMember();
const member = (
await Member.findOneOrFail({
where: { id: req.user_id },
select: PublicMemberProjection,
})
).toPublicMember();

await emitEvent({
event: "MESSAGE_REACTION_ADD",
Expand All @@ -243,8 +242,9 @@ router.put(
guild_id: channel.guild_id,
emoji,
member,
type: ReactionType.normal,
},
} as MessageReactionAddEvent);
} satisfies MessageReactionAddEvent);

res.sendStatus(204);
},
Expand Down Expand Up @@ -300,8 +300,9 @@ router.delete(
message_id,
guild_id: channel.guild_id,
emoji,
type: ReactionType.normal,
},
} as MessageReactionRemoveEvent);
} satisfies MessageReactionRemoveEvent);

res.sendStatus(204);
},
Expand Down Expand Up @@ -357,8 +358,9 @@ router.delete(
message_id,
guild_id: channel.guild_id,
emoji,
type: ReactionType.normal,
},
} as MessageReactionRemoveEvent);
} satisfies MessageReactionRemoveEvent);

res.sendStatus(204);
},
Expand Down
7 changes: 6 additions & 1 deletion src/util/interfaces/Event.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -376,7 +376,10 @@ export interface MessageDeleteBulkEvent extends Event {
guild_id?: string;
};
}

export const enum ReactionType {
normal = 0,
burst = 1,
}
export interface MessageReactionAddEvent extends Event {
event: "MESSAGE_REACTION_ADD";
data: {
Expand All @@ -386,6 +389,7 @@ export interface MessageReactionAddEvent extends Event {
guild_id?: string;
member?: PublicMember;
emoji: PartialEmoji;
type: ReactionType;
};
}

Expand All @@ -397,6 +401,7 @@ export interface MessageReactionRemoveEvent extends Event {
message_id: string;
guild_id?: string;
emoji: PartialEmoji;
type: ReactionType;
};
}

Expand Down
Loading