Support light backgroud for delta diffs#5
Open
cgimenes wants to merge 2 commits intospacedentist:masterfrom
Open
Support light backgroud for delta diffs#5cgimenes wants to merge 2 commits intospacedentist:masterfrom
cgimenes wants to merge 2 commits intospacedentist:masterfrom
Conversation
spacedentist
reviewed
Mar 2, 2026
Owner
spacedentist
left a comment
spacedentist
left a comment
There was a problem hiding this comment.
Thanks. Looks good. One little comment.
Co-authored-by: Sven Over <sp@cedenti.st>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a small but important usability improvement to the diff command generation logic. Now, the diff output will automatically adjust for light or dark backgrounds by passing the appropriate flag to
deltabased on the user's current Vim background setting.get_diff_commandfunction inlua/resolve/init.luato detect if the Vim background is set to "light" and, if so, append the--lightflag to thedeltacommand for improved readability in light-themed environments.