Fix dependency issue when disabling Wireguard#44
Open
olifre wants to merge 1 commit intospacedog:masterfrom
Open
Fix dependency issue when disabling Wireguard#44olifre wants to merge 1 commit intospacedog:masterfrom
olifre wants to merge 1 commit intospacedog:masterfrom
Conversation
When ensuring "absent", the service must be stopped before the config is removed, otherwise, stopping the service fails and the interface remains.
sorrison
pushed a commit
to NeCTAR-RC/puppet-wireguard
that referenced
this pull request
Apr 6, 2025
modulesync 5.2.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When disabling Wireguard, the config file must be purged only after the service is stopped, not before. Otherwise, stopping the service fails and the interface remains, and also re-enabling the service fails, since the interface is already there.
Fix this by flipping the order of dependencies for
absentvs.present.