fix: avoid panic on multibyte char boundary in log message truncation#176
Merged
Marenz merged 2 commits intospacedriveapp:mainfrom Feb 23, 2026
Merged
Conversation
Marenz
force-pushed
the
fix/log-truncation-char-boundary
branch
2 times, most recently
from
de63d62 to
867c535
Compare
Marenz
force-pushed
the
fix/log-truncation-char-boundary
branch
from
867c535 to
7419468
Compare
jamiepine
approved these changes
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tracing formatter truncated log messages at a fixed byte offset (280) using a direct string slice, causing a panic when the cut point landed inside a multibyte UTF-8 character (e.g. '→').
Use
floor_char_boundaryto find the nearest valid char boundary at or before the limit before slicing. Fixes both occurrences insrc/daemon.rs.Triggered by a shell tool result containing '→' in its stderr output.