fix: register groq/together/xai/mistral/deepseek providers from shorthand config keys#179
Merged
jamiepine merged 3 commits intospacedriveapp:mainfrom Feb 23, 2026
Merged
Conversation
![tembo[bot]](https://avatars.githubusercontent.com/in/1223475?s=60&v=4){kind=small}
Marenz
changed the title
deepseek_key was parsed and stored in LlmConfig but never inserted into the providers HashMap, causing 'unknown provider: deepseek' errors at runtime when deepseek appeared in a fallback chain. Same pattern as the nvidia fix (PR spacedriveapp#82) and ollama fix (PR spacedriveapp#175).
Add missing .entry() registration blocks for groq_key, together_key, xai_key, and mistral_key in both load_from_env and from_toml paths. Same pattern as the nvidia/ollama/deepseek fixes. Add two table-driven regression tests that verify every shorthand key field in LlmConfig actually registers a provider — so this class of bug is caught at test time instead of at runtime.
Marenz
force-pushed
the
fix/deepseek-provider
branch
from
68c0bf0 to
6ded550
Compare
jamiepine
approved these changes
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same pattern as nvidia (#82), ollama (#175): shorthand key fields parsed and stored in `LlmConfig` but never inserted into `providers`, causing "unknown provider" at runtime.
This PR fixes all remaining unregistered providers in one go:
Also adds two table-driven regression tests (`all_shorthand_keys_register_providers_via_toml` and `..._via_env`) that cover every shorthand key field — so this class of bug is caught at test time rather than at runtime.
Depends on #174.