Settings screen implementation #2934

jamiepine · 2025-12-25T11:33:10Z

This PR implements the initial phase of the settings screen, providing a functional interface for configuring core application and library-specific settings.

It introduces new backend operations for AppConfig and LibraryConfig to fetch and update settings, alongside 8 new frontend pages: General, Appearance, Library, Indexer, Services, Privacy, Advanced, and About. These pages integrate with the new backend operations, allowing users to manage various aspects of Spacedrive's behavior, from UI preferences to daemon services and indexing rules.

This lays the groundwork for future advanced configuration features.

Closes #(issue)

This commit introduces new settings pages for Appearance, Advanced, Indexer, Library, Privacy, and Services. It also adds core operations for getting and updating application and library configurations. Co-authored-by: ijamespine <[email protected]>

cursor · 2025-12-25T11:33:11Z

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
_{Learn more about Cursor Agents}

jamiepine · 2026-01-11T10:08:45Z

@cursor resolve the merge conflicts

cursor · 2026-01-11T10:08:52Z

Perfect! The merge conflicts have been successfully resolved. Let me create a summary of what was done:

Summary

I've successfully resolved the merge conflicts in the PR. Here's what was done:

Conflicts Resolved:

packages/interface/src/routes/settings/index.tsx - The main branch had a simpler inline settings implementation, while the PR branch has a more comprehensive structure with separate page components. I kept the PR's full implementation (with 8 settings pages: General, Appearance, Library, Indexer, Services, Privacy, Advanced, and About) and updated the import path from ./pages to ../../Settings/pages to correctly reference the settings pages directory.
bun.lockb - This binary lockfile had conflicts. I accepted the main branch version, which will be regenerated automatically when dependencies are installed in CI.

Result:

All conflicts resolved and merge completed successfully
The comprehensive settings implementation from the PR is preserved
All 8 settings page components remain intact in /packages/interface/src/Settings/pages/
The branch is now up to date with main and ready for review

_{Learn more about Cursor Agents}

Resolved merge conflicts: - Updated settings index.tsx import path to reference ../../Settings/pages - Accepted main branch version of bun.lockb

This commit introduces several improvements to the settings interface, including the addition of device name and slug fields in the GeneralSettings component. It also refactors the settings structure to utilize a more consistent context for state management. The UI has been updated with animations and improved styling for a better user experience. Additionally, the app now supports logging configuration updates and integrates React Query Devtools for enhanced debugging capabilities.

cursor · 2026-01-17T15:40:18Z

PR Summary

Implements a functional Settings experience with backend support for configuration.

Backend: add config.app.get/update and config.library.get/update (query/action) with typed outputs; new device.update action and slug exposed in core.status; switch indexer progress to phase-based percentage; export device::config; wire new endpoints in generated TS types
UI: new Settings pages (General, Appearance, Library, Indexer, Services, Privacy, Advanced, About) using useCoreQuery/Mutation and useLibraryQuery/Mutation; device name/slug editing and reset-all-data in General; service toggles with restart hint; visual polish (About page, themed sidebar) and React Query Devtools
Desktop: Tauri windows apply macOS hidden title and post-build titlebar styling for consistency

^{Written by Cursor Bugbot for commit f6a68d3. Configure here.}

tembo · 2026-01-17T15:41:58Z

apps/tauri/src/App.tsx

 	SpacedriveProvider,
 	ServerProvider,
 } from "@sd/interface";
+import { ReactQueryDevtools } from "@tanstack/react-query-devtools";


This import is unused - ReactQueryDevtools is not rendered in this file.

tembo · 2026-01-17T15:41:58Z

apps/tauri/src/App.tsx


 	// Route to different UIs based on window type
 	if (route === "/settings") {
+		console.log("[App] Rendering Settings route");


These debug console.log statements should be removed before merging.

tembo · 2026-01-17T15:41:58Z

packages/interface/src/routes/settings/index.tsx

+  AdvancedSettings,
+  AboutSettings,
+} from "../../Settings/pages";
+import { ReactQueryDevtools } from "@tanstack/react-query-devtools";


This import is unused here - ReactQueryDevtools is imported but the component using it was removed during refactoring.

tembo · 2026-01-17T15:41:58Z

packages/interface/src/routes/settings/index.tsx

+        buttonPosition="bottom-right"
+      />
+    </>
+  );


These debug console.log statements should be removed before merging.

tembo · 2026-01-17T15:42:05Z

packages/interface/src/Settings/pages/GeneralSettings.tsx

+    console.log("[GeneralSettings] Status query:", {
+      data: statusQuery.data,
+      isLoading: statusQuery.isLoading,
+      error: statusQuery.error,


Debug logging should be removed before merging. This entire useEffect block with console.log statements appears to be debugging code.

tembo · 2026-01-17T15:42:05Z

packages/interface/src/Settings/pages/GeneralSettings.tsx

+    },
+  });
+
+  const onDeviceSubmit = deviceForm.handleSubmit(async (data) => {


Consider validating form state before submission. The handleSubmit wrapper should prevent submission while pending, but the button's disabled state relies on updateDevice.isPending which may not cover all edge cases (e.g., during validation).

tembo · 2026-01-17T15:42:12Z

packages/interface/src/Settings/pages/ServicesSettings.tsx

+        </p>
+      </div>
+
+      <form onSubmit={onSubmit} className="space-y-4">


Using alert() for user notifications isn't ideal for a polished UI. Consider using a toast notification or modal component for a better user experience.

tembo · 2026-01-17T15:42:12Z

packages/interface/src/Settings/pages/GeneralSettings.tsx

+          onSuccess: (result) => {
+            alert(
+              result.message || "Data has been reset. Please restart the application."
+            );


Using window.confirm() and alert() for user interactions isn't consistent with a modern application UX. Consider using a custom modal/dialog component from your UI library instead.

tembo · 2026-01-17T15:42:20Z

packages/interface/src/Settings/pages/AdvancedSettings.tsx

+  const { data: config, refetch } = useCoreQuery({ type: "config.app.get", input: null as any });
+  const updateConfig = useCoreMutation("config.app.update");
+
+  const form = useForm<AdvancedSettingsForm>({


The input type passed to useCoreQuery uses null as any which bypasses type safety. Consider using the proper input type from the generated types, or if the input is truly null/empty, use the appropriate type definition.

tembo · 2026-01-17T15:42:20Z

packages/interface/src/Settings/pages/IndexerSettings.tsx

+  const libraryId = client.getCurrentLibraryId();
+  const { data: config, refetch, isLoading } = useLibraryQuery(
+    { type: "config.library.get", input: null as any },
+    { enabled: !!libraryId }


Same issue here - null as any bypasses type checking. The generated types should have proper input type definitions for these queries.

tembo · 2026-01-17T15:42:27Z

core/src/ops/config/app/update.rs

+		// Validate language (basic ISO 639-1 check)
+		if let Some(ref lang) = self.input.language {
+			if lang.len() != 2 || !lang.chars().all(|c| c.is_ascii_lowercase()) {
+				return Err(ActionError::Validation {


The language validation is restrictive to exactly 2-character ISO 639-1 codes. However, some locales use extended tags like zh-CN or pt-BR for regional variants. Consider whether this validation should be relaxed or if these cases will be handled differently.

cursor

Cursor Bugbot has reviewed your changes and found 3 potential issues.

^{Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.}

cursor · 2026-01-17T15:46:40Z

packages/interface/src/Settings/pages/GeneralSettings.tsx

+  const client = useSpacedriveClient();
+  const statusQuery = useCoreQuery({ type: "core.status", input: null as any });
+  const configQuery = useCoreQuery({ type: "config.app.get", input: null as any });
+  const updateDevice = useCoreMutation("device.update");


Device update action missing from generated TypeScript bindings

High Severity

The device.update action is registered in the backend (UpdateDeviceAction with register_core_action!) but the corresponding TypeScript types and wire method mappings were not generated. GeneralSettings.tsx uses useCoreMutation("device.update") which will fail at runtime because WIRE_METHODS.coreActions["device.update"] is undefined. The @ts-nocheck directive in useMutation.ts prevents TypeScript from catching this at compile time. This breaks the device name/slug editing functionality in the General Settings page.

Additional Locations (1)

core/src/ops/devices/update.rs#L120-L121

packages/interface/src/Settings/pages/GeneralSettings.tsx

core/src/ops/devices/update.rs

…nt structure This commit cleans up the GeneralSettings and Settings components by removing redundant logging statements and the use of the Spacedrive client where it is no longer needed. Additionally, it updates the DeviceInfo type to include a slug field and introduces new types for device configuration updates, enhancing the overall structure and clarity of the codebase.

cursoragent and others added 3 commits January 11, 2026 10:11

Merge branch 'main' into cursor/settings-screen-implementation-98d1

79a54cc

Resolved merge conflicts: - Updated settings index.tsx import path to reference ../../Settings/pages - Accepted main branch version of bun.lockb

Merge branch 'main' into cursor/settings-screen-implementation-98d1

6d51ba6

jamiepine marked this pull request as ready for review January 17, 2026 15:40

tembo bot reviewed Jan 17, 2026

View reviewed changes

cursor bot reviewed Jan 17, 2026

View reviewed changes

jamiepine merged commit 802d345 into main Jan 17, 2026
1 of 4 checks passed

jamiepine deleted the cursor/settings-screen-implementation-98d1 branch January 17, 2026 15:55

Uh oh!

Settings screen implementation #2934

Settings screen implementation #2934

Conversation

jamiepine commented Dec 25, 2025

Uh oh!

cursor bot commented Dec 25, 2025

Uh oh!

jamiepine commented Jan 11, 2026

Uh oh!

cursor bot commented Jan 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Uh oh!

cursor bot commented Jan 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Summary

Uh oh!

tembo bot Jan 17, 2026

Choose a reason for hiding this comment

Uh oh!

tembo bot Jan 17, 2026

Choose a reason for hiding this comment

Uh oh!

tembo bot Jan 17, 2026

Choose a reason for hiding this comment

Uh oh!

tembo bot Jan 17, 2026

Choose a reason for hiding this comment

Uh oh!

tembo bot Jan 17, 2026

Choose a reason for hiding this comment

Uh oh!

tembo bot Jan 17, 2026

Choose a reason for hiding this comment

Uh oh!

tembo bot Jan 17, 2026

Choose a reason for hiding this comment

Uh oh!

tembo bot Jan 17, 2026

Choose a reason for hiding this comment

Uh oh!

tembo bot Jan 17, 2026

Choose a reason for hiding this comment

Uh oh!

tembo bot Jan 17, 2026

Choose a reason for hiding this comment

Uh oh!

tembo bot Jan 17, 2026

Choose a reason for hiding this comment

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Uh oh!

cursor bot Jan 17, 2026

Choose a reason for hiding this comment

Device update action missing from generated TypeScript bindings

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

cursor bot commented Jan 11, 2026 •

edited

Loading

cursor bot commented Jan 17, 2026 •

edited

Loading