Skip to content

Fix listing spacectl releases on GHE#37

Merged
eliecharra merged 1 commit intomainfrom
fix-listing-versions
Jul 28, 2025
Merged

Fix listing spacectl releases on GHE#37
eliecharra merged 1 commit intomainfrom
fix-listing-versions

Conversation

@mbialon
Copy link
Copy Markdown
Contributor

@mbialon mbialon commented May 21, 2025

Closes #36

@mbialon mbialon self-assigned this May 21, 2025
@mbialon mbialon requested a review from a team as a code owner May 21, 2025 13:47
Copy link
Copy Markdown
Member

@eliecharra eliecharra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a nasty one 👌🏻

@peterdeme
Copy link
Copy Markdown
Collaborator

@mbialon wanna merge it?

@eliecharra
Copy link
Copy Markdown
Member

@peterdeme Marcin is on holiday but I think we should merge this 👍🏻

@eliecharra eliecharra merged commit b356a96 into main Jul 28, 2025
7 checks passed
@eliecharra eliecharra deleted the fix-listing-versions branch July 28, 2025 10:40
@msamendinger
Copy link
Copy Markdown

@eliecharra @mbialon it probably should be mentioned in the docs that running setup-spacectl on GHE makes the use of github-token obligatory.

@peterdeme
Copy link
Copy Markdown
Collaborator

Mentioned now: #40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Running on GHES tries to list releases on GHES instead of github.com

4 participants