Merged
Conversation
4fb4c28 to
58bb5de
Compare
peterdeme
commented
Aug 14, 2025
|
|
||
| ### Graceful Spot Instance Interruption Handling | ||
|
|
||
| The Spacelift worker includes built-in spot instance interruption detection to minimize job disruption: |
Contributor
Author
There was a problem hiding this comment.
This is a recent development in the worker code that I did last night. I'm still testing it.
Contributor
Author
Signed-off-by: peterdeme <demepeter93@gmail.com>
58bb5de to
2ea3b0b
Compare
TheOutdoorProgrammer
requested changes
Aug 15, 2025
Member
TheOutdoorProgrammer
left a comment
There was a problem hiding this comment.
is this just the example and docs? where is the rest?
Contributor
Author
|
@Apollorion there is no rest, this is just documentation. we were always compatible with spot, we just never really recommended them. |
TheOutdoorProgrammer
approved these changes
Aug 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Description of the change
I have looked into our launcher/worker code recently and I have noticed that it'd quite easy to detect Spot Instance interruption signals, so I implemented a graceful shutdown behavior in our code.
I thought I'll explicitly mention some details in our TF module as well. If it functions as I expect it to, I'll extend our official documentation as well.
edit: I was able to test it and it works :)
Type of change
Checklists
Development
Code review