Skip to content

Cu 8699yp7ej enable fips#183

Closed
oscartospacelift wants to merge 3 commits intomainfrom
CU-8699yp7ej_enableFIPS
Closed

Cu 8699yp7ej enable fips#183
oscartospacelift wants to merge 3 commits intomainfrom
CU-8699yp7ej_enableFIPS

Conversation

@oscartospacelift
Copy link
Contributor

Description of the change

Description here

Type of change

  • Bug fix (non-breaking change that fixes an issue);
  • New feature (non-breaking change that adds functionality);
  • Breaking change (fix or feature that would cause existing functionality to not work as expected);
  • Documentation (a documentation or example fix not affecting the infrastructure managed by this module);

Checklists

Development

  • All necessary variables have been defined, with defaults if applicable;
  • The code is formatted properly;

Code review

  • The module version is bumped accordingly;
  • Spacelift tests are passing;
  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached;
  • This pull request is no longer marked as "draft";
  • Reviewers have been assigned;
  • Changes have been reviewed by at least one other engineer;

@oscartospacelift
Copy link
Contributor Author

Hmm, changes should be there, did anyone reverted it already?
@adamconnelly maybe?

@adamconnelly
Copy link
Contributor

@oscartospacelift nope - you can see them in main here:

if [[ -n "$fedrampSuffix" ]]; then
.

It looks like your git history isn't quite right. Maybe pull main then rebase your branch and check if it fixes it?

@oscartospacelift oscartospacelift deleted the CU-8699yp7ej_enableFIPS branch September 16, 2025 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants