Skip to content

Conversation

fasmat
Copy link
Member

@fasmat fasmat commented Dec 19, 2024

Motivation

This updates go-libp2p to the most recent v0.38.1.

Description

The only non-backwards compatible change that affects us seems to be the introduction of this feature: libp2p/go-libp2p#2984 Since we are not using shared connections the fix should be simple.

Test Plan

  • existing tests pass

TODO

  • Explain motivation or link existing issue(s)
  • Test changes and document test plan
  • Update documentation as needed
  • Update changelog as needed

@fasmat fasmat self-assigned this Dec 19, 2024
@fasmat
Copy link
Member Author

fasmat commented Dec 19, 2024

bors try

spacemesh-bors bot added a commit that referenced this pull request Dec 19, 2024
Copy link

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.8%. Comparing base (87095b3) to head (21f2215).
Report is 1 commits behind head on develop.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff            @@
##           develop   #6556     +/-   ##
=========================================
- Coverage     79.8%   79.8%   -0.1%     
=========================================
  Files          354     354             
  Lines        47015   47015             
=========================================
- Hits         37537   37519     -18     
- Misses        7345    7367     +22     
+ Partials      2133    2129      -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@spacemesh-bors
Copy link

try

Build succeeded:

@fasmat
Copy link
Member Author

fasmat commented Dec 19, 2024

bors merge

spacemesh-bors bot pushed a commit that referenced this pull request Dec 19, 2024
## Motivation

This updates go-libp2p to the most recent v0.38.1.
@spacemesh-bors
Copy link

Build failed:

@fasmat
Copy link
Member Author

fasmat commented Dec 19, 2024

flaky TestAdminEvents on a differently configured (?) windows runner

bors merge

spacemesh-bors bot pushed a commit that referenced this pull request Dec 19, 2024
## Motivation

This updates go-libp2p to the most recent v0.38.1.
@spacemesh-bors
Copy link

Build failed:

@fasmat
Copy link
Member Author

fasmat commented Dec 19, 2024

flaky systest

bors merge

spacemesh-bors bot pushed a commit that referenced this pull request Dec 19, 2024
## Motivation

This updates go-libp2p to the most recent v0.38.1.
@spacemesh-bors
Copy link

Build failed:

  • ci-status

@fasmat
Copy link
Member Author

fasmat commented Dec 19, 2024

flaky Test_GetAtxsLimiting, reopening issue: #6113

bors merge

spacemesh-bors bot pushed a commit that referenced this pull request Dec 19, 2024
## Motivation

This updates go-libp2p to the most recent v0.38.1.
@spacemesh-bors
Copy link

Pull request successfully merged into develop.

Build succeeded:

@spacemesh-bors spacemesh-bors bot changed the title Update go-libp2p [Merged by Bors] - Update go-libp2p Dec 19, 2024
@spacemesh-bors spacemesh-bors bot closed this Dec 19, 2024
@spacemesh-bors spacemesh-bors bot deleted the update-go-libp2p branch December 19, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants